test(viewer): help_overlay shortcut proptest surface (WBS-6.2 #455) - #467
test(viewer): help_overlay shortcut proptest surface (WBS-6.2 #455)#467KooshaPari wants to merge 3 commits into
Conversation
Adds crates/sl-viewer/tests/properties_viewer_mock_data.rs with 18
proptest properties pinning the deterministic demo fixtures:
* sample_bundles():
* Non-empty, returns the documented 3-entry sample.
* Every source_id is non-empty and unique.
* Every ContinuationBundle has at least one Bundle slice, at
least one Intent slice, and an Intent with a non-empty goal.
* Every Acceptance slice carries ready: true.
* Deterministic across calls.
* sample_sessions():
* Non-empty, returns the documented 3-entry sample.
* Every session id is non-empty and unique.
* Every session has at least one non-empty-content message.
* Every session has non-empty cwd and title.
* Every session contains at least one User and one Assistant
message so the timeline UI can render both sides.
* Deterministic across calls.
Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
Adds two complementary property surfaces for sl-viewer's pure
data-reducers:
* crates/sl-viewer/tests/properties_viewer_theme.rs (28 props):
- Theme::default() is System; JSON round-trips for every variant.
- ThemeColors::dark and ThemeColors::light each expose 9 fields
that all match the documented lab_coat::* constants; every
field is non-empty; focus == accent for both palettes.
- for_theme(Dark|Light|System) is the documented palette.
* crates/sl-viewer/tests/properties_viewer_settings.rs (21 props):
- DefaultTab::default() is Bundles; ALL covers every variant,
length 9, every tab_id/value_attr unique kebab-case ASCII.
- Settings::default() matches documented; JSON round-trips;
serialised theme is lowercase, default_tab is kebab-case.
- save_to_path / load_from_path round-trip; missing/corrupt
files fall back to default(); parent dirs created.
- resolve_settings_dir honours overrides; falls through on
empty; picks documented macOS / Windows / Linux paths.
Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
Adds crates/sl-viewer/tests/properties_viewer_help_overlay.rs with 13 proptest properties pinning the keyboard help SSOT: * SHORTCUTS is non-empty. * Every shortcut has non-empty keys / scope / action. * Every action is descriptive (has at least one ASCII letter) and human-readable (no ERR_ / error code leaks). * Every (keys, scope) pair is unique so the rendered table does not collide on its React key. * The ?, Escape, and Cmd+K / Ctrl+K shortcuts are present. * Every scope is one of the documented panel scopes. * Every keys is non-blank. Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 44 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:XL
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| let resolved_str = resolved.to_string_lossy().to_string(); | ||
| // Expected fragment depends on platform; we just assert the | ||
| // override path was bypassed (i.e. the result is not `""`). | ||
| prop_assert!(!resolved_str.is_empty(), "resolved path is empty"); | ||
| // The fallback never equals the override path. | ||
| prop_assert_ne!( | ||
| resolved_str, | ||
| Path::new("").to_string_lossy().to_string(), | ||
| ); |
There was a problem hiding this comment.
Suggestion: The empty-override property only checks that the returned path is non-empty and differs from an empty path, which would pass for any incorrect directory. This does not verify the documented platform-specific fallback and therefore cannot detect a regression that redirects persisted settings to the wrong location. Assert the exact expected path for each supported target, using the supplied home/appdata/XDG inputs. [possible bug]
Severity Level: Major ⚠️
- ⚠️ Incorrect platform fallback paths remain undetected.
- ❌ Persisted viewer settings may be written elsewhere.
- ⚠️ Empty override behavior is only partially verified.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_settings.rs
**Line:** 268:276
**Comment:**
*Possible Bug: The empty-override property only checks that the returned path is non-empty and differs from an empty path, which would pass for any incorrect directory. This does not verify the documented platform-specific fallback and therefore cannot detect a regression that redirects persisted settings to the wrong location. Assert the exact expected path for each supported target, using the supplied home/appdata/XDG inputs.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| fn resolve_settings_dir( | ||
| override_dir: Option<&str>, | ||
| home: Option<&OsStr>, | ||
| appdata: Option<&OsStr>, | ||
| xdg_config: Option<&OsStr>, | ||
| ) -> Option<PathBuf> { | ||
| if let Some(dir) = override_dir { | ||
| if !dir.is_empty() { | ||
| return Some(PathBuf::from(dir)); | ||
| } | ||
| } | ||
|
|
||
| if cfg!(target_os = "macos") { | ||
| let home = home?; | ||
| return Some( | ||
| PathBuf::from(home).join("Library").join("Application Support").join("SessionLedger"), | ||
| ); | ||
| } | ||
|
|
||
| if cfg!(target_os = "windows") { | ||
| if let Some(appdata) = appdata { | ||
| return Some(PathBuf::from(appdata).join("SessionLedger")); | ||
| } | ||
| if let Some(home) = home { | ||
| return Some(PathBuf::from(home).join("AppData").join("Roaming").join("SessionLedger")); | ||
| } | ||
| return None; | ||
| } | ||
|
|
||
| if let Some(xdg) = xdg_config { | ||
| return Some(PathBuf::from(xdg).join("SessionLedger")); | ||
| } | ||
| let home = home?; | ||
| Some(PathBuf::from(home).join(".config").join("SessionLedger")) |
There was a problem hiding this comment.
Suggestion: This helper is a second implementation of the production resolver rather than a call to Settings::dir() or the production resolve_settings_dir. Consequently, all resolver properties can pass while settings.rs has a different override precedence, platform branch, or fallback path. Expose the production pure resolver to integration tests or test the public API through controlled dependency injection instead of duplicating its logic. [incomplete implementation]
Severity Level: Major ⚠️
- ❌ Platform resolver regressions can pass CI.
- ⚠️ `Settings::dir()` behavior lacks integration coverage.
- ⚠️ Settings may persist under an incorrect OS path.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_settings.rs
**Line:** 347:380
**Comment:**
*Incomplete Implementation: This helper is a second implementation of the production resolver rather than a call to `Settings::dir()` or the production `resolve_settings_dir`. Consequently, all resolver properties can pass while `settings.rs` has a different override precedence, platform branch, or fallback path. Expose the production pure resolver to integration tests or test the public API through controlled dependency injection instead of duplicating its logic.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| // appear under multiple scopes (e.g. `Escape` is a multi-scope | ||
| // close). We assert that at least one key appears more than once | ||
| // is reasonable; the strong check is the (keys, scope) pair. | ||
| let _ = (keys.len(), SHORTCUTS.len()); |
There was a problem hiding this comment.
WARNING: shortcuts_keys_unique is a no-op test — it computes (keys.len(), SHORTCUTS.len()) and discards the tuple without any assertion.
The comment on lines 121–124 acknowledges this should assert something, but the body never checks keys.len() < SHORTCUTS.len() or any other condition. As written the test always passes and provides zero coverage for key uniqueness.
| let _ = (keys.len(), SHORTCUTS.len()); | |
| prop_assert!(keys.len() < SHORTCUTS.len(), "duplicate keys found across scopes"); |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| #[test] | ||
| fn resolve_settings_dir_windows_uses_appdata(_seed in any::<u32>()) { | ||
| let appdata = OsStr::new("C:/Users/agent/AppData/Roaming"); | ||
| let resolved = resolve_settings_dir(None, None, Some(appdata), None); |
There was a problem hiding this comment.
WARNING: resolve_settings_dir_windows_uses_appdata passes None for home on non-Windows platforms. On Linux the resolver returns None (not the Windows path), and on macOS it returns the macOS path. The test name implies it verifies Windows path logic, but the Windows branch is only actually exercised on Windows.
The else-branch then supplies a home value and only asserts is_some(), which passes regardless of whether the Windows branch is correct. A regression in the Windows branch would go undetected on Linux/macOS CI.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (6 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash · Input: 104.2K · Output: 20.5K · Cached: 981.5K |
User description
Summary
Adds
crates/sl-viewer/tests/properties_viewer_help_overlay.rswith 13 proptest properties pinning the keyboard help overlay'sSHORTCUTSSSOT (WBS-6.2 #455).SHORTCUTS(13 properties)keys/scope/action.actionis descriptive (has at least one ASCII letter).actionis human-readable (noERR_/error codeleaks).(keys, scope)pair is unique so the rendered table does not collide on its React-style key.?help toggle,Escapeclose, andCmd+K / Ctrl+Kcommand palette shortcuts are present.scopeis one of the documented panel scopes.keysis non-blank.Validation
cargo test -p sl-viewer --test properties_viewer_help_overlay --features "desktop parquet" --locked— 13 passedcargo fmt --all --check— cleanWBS / TRACEABILITY
WBS-6.2 evidence list and
TRACEABILITY.jsongaincrates/sl-viewer/tests/properties_viewer_help_overlay.rs. CHANGELOG Unreleased documents the new surface.CodeAnt-AI Description
Add property coverage for viewer themes, settings, and keyboard help
What Changed
Impact
✅ Fewer theme color regressions✅ Safer settings recovery after missing or corrupt files✅ Clearer and more reliable keyboard help💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.