test(viewer): mock_data fixture proptest surface (WBS-6.2 #451) - #454
test(viewer): mock_data fixture proptest surface (WBS-6.2 #451)#454KooshaPari wants to merge 1 commit into
Conversation
Adds crates/sl-viewer/tests/properties_viewer_mock_data.rs with 18
proptest properties pinning the deterministic demo fixtures:
* sample_bundles():
* Non-empty, returns the documented 3-entry sample.
* Every source_id is non-empty and unique.
* Every ContinuationBundle has at least one Bundle slice, at
least one Intent slice, and an Intent with a non-empty goal.
* Every Acceptance slice carries ready: true.
* Deterministic across calls.
* sample_sessions():
* Non-empty, returns the documented 3-entry sample.
* Every session id is non-empty and unique.
* Every session has at least one non-empty-content message.
* Every session has non-empty cwd and title.
* Every session contains at least one User and one Assistant
message so the timeline UI can render both sides.
* Deterministic across calls.
Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 48 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:L
|
Closing due to merge conflicts. |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| for cb in &sample_bundles() { | ||
| for b in cb.bundles.iter().filter(|b| b.kind == BundleKind::Acceptance) { | ||
| let ready = b.body.get("ready").and_then(|v| v.as_bool()); | ||
| prop_assert_eq!(ready, Some(true)); | ||
| } |
There was a problem hiding this comment.
Suggestion: The loop is vacuous when a continuation bundle contains no Acceptance slice, so removing all acceptance gates would still pass this test even though ContinuationBundle::is_injectable() and the viewer readiness badge require one. Assert that every continuation bundle has at least one Acceptance bundle before validating its ready field. [incomplete implementation]
Severity Level: Major ⚠️
- ❌ Demo bundle can lose its injectable acceptance gate.
- ⚠️ Viewer readiness state can silently show an incomplete fixture.
- ⚠️ Regression test passes despite missing acceptance coverage.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_mock_data.rs
**Line:** 114:118
**Comment:**
*Incomplete Implementation: The loop is vacuous when a continuation bundle contains no `Acceptance` slice, so removing all acceptance gates would still pass this test even though `ContinuationBundle::is_injectable()` and the viewer readiness badge require one. Assert that every continuation bundle has at least one `Acceptance` bundle before validating its `ready` field.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| for (x, y) in a.iter().zip(b.iter()) { | ||
| prop_assert_eq!(&x.id, &y.id); | ||
| prop_assert_eq!(&x.cwd, &y.cwd); | ||
| prop_assert_eq!(&x.title, &y.title); |
There was a problem hiding this comment.
Suggestion: The session determinism check also omits Session::corpus, which is rendered in corpus labels and used for corpus breakdowns. A fixture could change a session's corpus and still pass this test; compare x.corpus and y.corpus as well. [incomplete implementation]
Severity Level: Major ⚠️
- ⚠️ Mock corpus badges can silently display wrong providers.
- ⚠️ Corpus breakdown counts can change unnoticed.
- ⚠️ History timeline carries corpus into rendered labels.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_mock_data.rs
**Line:** 222:225
**Comment:**
*Incomplete Implementation: The session determinism check also omits `Session::corpus`, which is rendered in corpus labels and used for corpus breakdowns. A fixture could change a session's corpus and still pass this test; compare `x.corpus` and `y.corpus` as well.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| for (mx, my) in x.messages.iter().zip(y.messages.iter()) { | ||
| prop_assert_eq!(mx.role, my.role); | ||
| prop_assert_eq!(&mx.content, &my.content); |
There was a problem hiding this comment.
Suggestion: The session determinism check compares roles and content but omits every message's ts_ms. Those timestamps drive session ordering and last-activity display, so changing or dropping them would alter the viewer while this test still passes. Include each message timestamp in the comparison. [incomplete implementation]
Severity Level: Major ⚠️
- ⚠️ Mock Raw Sessions activity dates can drift silently.
- ⚠️ Session ordering can change after timestamp edits.
- ⚠️ Determinism property omits rendered temporal metadata.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_viewer_mock_data.rs
**Line:** 227:229
**Comment:**
*Incomplete Implementation: The session determinism check compares roles and content but omits every message's `ts_ms`. Those timestamps drive session ordering and last-activity display, so changing or dropping them would alter the viewer while this test still passes. Include each message timestamp in the comparison.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix* test(viewer): mock_data fixture proptest surface (WBS-6.2 #451) Adds crates/sl-viewer/tests/properties_viewer_mock_data.rs with 18 proptest properties pinning the deterministic demo fixtures: * sample_bundles(): * Non-empty, returns the documented 3-entry sample. * Every source_id is non-empty and unique. * Every ContinuationBundle has at least one Bundle slice, at least one Intent slice, and an Intent with a non-empty goal. * Every Acceptance slice carries ready: true. * Deterministic across calls. * sample_sessions(): * Non-empty, returns the documented 3-entry sample. * Every session id is non-empty and unique. * Every session has at least one non-empty-content message. * Every session has non-empty cwd and title. * Every session contains at least one User and one Assistant message so the timeline UI can render both sides. * Deterministic across calls. Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG. * test(viewer): theme + settings property surfaces (WBS-6.2 #454) Adds two complementary property surfaces for sl-viewer's pure data-reducers: * crates/sl-viewer/tests/properties_viewer_theme.rs (28 props): - Theme::default() is System; JSON round-trips for every variant. - ThemeColors::dark and ThemeColors::light each expose 9 fields that all match the documented lab_coat::* constants; every field is non-empty; focus == accent for both palettes. - for_theme(Dark|Light|System) is the documented palette. * crates/sl-viewer/tests/properties_viewer_settings.rs (21 props): - DefaultTab::default() is Bundles; ALL covers every variant, length 9, every tab_id/value_attr unique kebab-case ASCII. - Settings::default() matches documented; JSON round-trips; serialised theme is lowercase, default_tab is kebab-case. - save_to_path / load_from_path round-trip; missing/corrupt files fall back to default(); parent dirs created. - resolve_settings_dir honours overrides; falls through on empty; picks documented macOS / Windows / Linux paths. Updates WBS-6.2 evidence list, TRACEABILITY.json, and CHANGELOG. --------- Co-authored-by: SessionLedger Bot <team@sessionledger.local>
User description
Summary
Adds
crates/sl-viewer/tests/properties_viewer_mock_data.rswith 18 proptest properties pinning themock_data::sample_bundlesandmock_data::sample_sessionsdeterministic fixture shapes (WBS-6.2 #451).sample_bundles()(9 properties)source_idis non-empty.source_idis unique across the sample.ContinuationBundlehas at least oneBundleslice.ContinuationBundlehas at least oneIntentslice.Intentslice carries a non-emptygoalfield.Acceptanceslice carriesready: true.sample_sessions()(9 properties)content.cwdandtitle.Userand oneAssistantmessage.Validation
cargo test -p sl-viewer --test properties_viewer_mock_data --features "desktop parquet" --locked— 18 passedcargo fmt --all --check— cleanWBS / TRACEABILITY
WBS-6.2 evidence list and
TRACEABILITY.jsongaincrates/sl-viewer/tests/properties_viewer_mock_data.rs. CHANGELOG Unreleased documents the new surface.CodeAnt-AI Description
Pin the viewer’s demo fixture data to the shapes required by the UI
What Changed
Impact
✅ Stable viewer demo bundles✅ Complete session timelines✅ Fewer silent screenshot and preview regressions💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.