Skip to content

feat(ops): default-on platform allocators (W43-B3, C00 L8) - #349

Merged
KooshaPari merged 2 commits into
mainfrom
feat/sl-w43-jemalloc-default-on
Jul 23, 2026
Merged

feat(ops): default-on platform allocators (W43-B3, C00 L8)#349
KooshaPari merged 2 commits into
mainfrom
feat/sl-w43-jemalloc-default-on

Conversation

@KooshaPari

Copy link
Copy Markdown
Owner

Summary

  • Default-on platform allocator policy for sl-daemon (C00 L8): jemalloc on Unix, mimalloc on Windows via platform-allocator default feature
  • Adds docs/ops/jemalloc-default-on.md, jemalloc-default-on.json, scripts/jemalloc-default-on-check.ps1 -SelfCheck, blocking jemalloc-default-on-hard.yml, tests/jemalloc_default_on.rs
  • Retains soft/hard explicit --features jemalloc CI evidence; continuous profiling push remains unpaid

Test plan

  • pwsh ./scripts/jemalloc-default-on-check.ps1 -SelfCheck
  • pwsh ./scripts/jemalloc-check.ps1 -SelfCheck
  • cargo test --test jemalloc_default_on --test jemalloc_hard --test jemalloc_soft --locked
  • cargo build (Windows default features / mimalloc)

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@KooshaPari, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ec428358-e706-42bb-bfd4-f4387324d327

📥 Commits

Reviewing files that changed from the base of the PR and between 54d7e7c and 4dbd4f1.

⛔ Files ignored due to path filters (1)
  • crates/sl-daemon/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (10)
  • .github/workflows/jemalloc-default-on-hard.yml
  • CHANGELOG.md
  • crates/sl-daemon/Cargo.toml
  • crates/sl-daemon/src/main.rs
  • docs/ops/jemalloc-default-on.json
  • docs/ops/jemalloc-default-on.md
  • docs/ops/jemalloc.md
  • scripts/jemalloc-check.ps1
  • scripts/jemalloc-default-on-check.ps1
  • tests/jemalloc_default_on.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/sl-w43-jemalloc-default-on
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/sl-w43-jemalloc-default-on

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

socket-security Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcargo/​mimalloc@​0.1.5210010093100100

View full report

KooshaPari and others added 2 commits July 22, 2026 19:30
Unix jemalloc + Windows mimalloc via platform-allocator default feature;
blocking jemalloc-default-on-hard.yml SelfCheck + platform builds.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@KooshaPari
KooshaPari force-pushed the feat/sl-w43-jemalloc-default-on branch from 0c3564c to 4dbd4f1 Compare July 23, 2026 02:31
@KooshaPari
KooshaPari merged commit fd90c12 into main Jul 23, 2026
108 of 109 checks passed
@KooshaPari
KooshaPari deleted the feat/sl-w43-jemalloc-default-on branch July 23, 2026 02:40
KooshaPari added a commit that referenced this pull request Jul 24, 2026
* feat(macos): add safe local app installer

* fix(daemon): fail fast when HTTP bind is unavailable

* fix(viewer): open inbox detail and make sessions keyboard accessible

* fix(macos): make packaging scripts executable

* feat(daemon): auto-discover native session roots

* fix(viewer): make detail scroll region keyboard accessible

* fix(ci): include make in hermetic allocator builder

* feat(macos): add opt-in auto-discovery launch agent

* docs(macos): print auto-discovery daemon command

* docs(packaging): make auto-discovery the default

* fix(ci): pin published hermetic builder digest

* docs(reaudit): Wave-43-D closure (#362 merge) refresh at commit 41829e8

- SCORECARD.md: header refreshed (date/auditor/commit), Wave-43 Delta section
  added, Wave-41/42/43 line, Held (no score) expansion incl #348/#349/#361/#362,
  Remaining unpaid rewrite.
- TRACEABILITY.json: updated 2026-07-21 -> 2026-07-23; commit d5f999f -> 41829e8;
  wave Wave-42 -> Wave-43; +delta_vs_w42 note. CRLF preserved.
- GAP_QA_MATRIX.md: C00 row + PLAN-W8-B row updated.
- CHANGELOG.md: Unreleased Changed entry for Wave-43-D reaudit.

Score 396/402 (98% A) held conservative; WAVE43 impl lanes deepened residual
evidence only (per WBS-8.3/8.5/8.7 pattern).

---------

Co-authored-by: KooshaPari <koosha@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant