Keep active on restart #1632

smk762 · 2022-02-24T18:05:13Z

When resetting assets, this will preserve active coins.
Closes #1544 and #1632

src/core/atomicdex/pages/qt.settings.page.cpp

merge from dev

tonymorony · 2022-03-02T10:02:11Z

on OSX app doesn't restart automatically for me after reset (didn't test on other OS yet)

coins list remain the same after restart, so this part works fine

relevant log:

[17:01:24] [info] [app.cpp:801] [2702049]: restarting the application
[17:01:24] [error] [app.cpp:815] [2702049]: Couldn't start a new process
[17:01:24] [debug] [app.cpp:651] [2702049]: will quit app, prevent all threading event
[17:01:24] [info] [mm2.service.cpp:295] [2702049]: destroying mm2 service...
[17:01:24] [info] [mm2.service.cpp:299] [2702049]: mm2 signals successfully disconnected
[17:01:24] [info] [mm2.service.cpp:307] [2702049]: processing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:303] [2702049]: preparing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:310] [2702049]: mm2 stop batch answer received
[17:01:24] [info] [mm2.service.cpp:315] [2702049]: mm2 successfully stopped with rpc stop
[17:01:24] [info] [mm2.service.cpp:346] [2702049]: mm2 init thread destroyed
[17:01:24] [info] [mm2.service.cpp:348] [2702049]: mm2 service fully destroyed
[17:01:24] [info] [main.prerequisites.hpp:216] [2702049]: wally successfully cleaned
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [info] [qt.orders.widget.cpp:35] [2702049]: qt_orders widget destroyed
[17:01:24] [info] [coingecko.wallet.charts.cpp:44] [2702049]: coingecko_wallet_charts_service destroyed

tonymorony

^^

ghost · 2022-03-02T13:15:05Z

on OSX app doesn't restart automatically for me after reset (didn't test on other OS yet)

coins list remain the same after restart, so this part works fine

relevant log:

[17:01:24] [info] [app.cpp:801] [2702049]: restarting the application
[17:01:24] [error] [app.cpp:815] [2702049]: Couldn't start a new process
[17:01:24] [debug] [app.cpp:651] [2702049]: will quit app, prevent all threading event
[17:01:24] [info] [mm2.service.cpp:295] [2702049]: destroying mm2 service...
[17:01:24] [info] [mm2.service.cpp:299] [2702049]: mm2 signals successfully disconnected
[17:01:24] [info] [mm2.service.cpp:307] [2702049]: processing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:303] [2702049]: preparing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:310] [2702049]: mm2 stop batch answer received
[17:01:24] [info] [mm2.service.cpp:315] [2702049]: mm2 successfully stopped with rpc stop
[17:01:24] [info] [mm2.service.cpp:346] [2702049]: mm2 init thread destroyed
[17:01:24] [info] [mm2.service.cpp:348] [2702049]: mm2 service fully destroyed
[17:01:24] [info] [main.prerequisites.hpp:216] [2702049]: wally successfully cleaned
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [info] [qt.orders.widget.cpp:35] [2702049]: qt_orders widget destroyed
[17:01:24] [info] [coingecko.wallet.charts.cpp:44] [2702049]: coingecko_wallet_charts_service destroyed

Are you sure it does not happen also on dev ? Because this PR does not modify the app starting logic

smk762 · 2022-03-02T15:10:58Z

Seems to be working ok here on mac mini. maybe we need more delay time between shut down and restart on faster systems?

tonymorony · 2022-03-02T19:45:07Z

Are you sure it does not happen also on dev ? Because this PR does not modify the app starting logic

just rechecked - restarting automagically for me on latest dev

Seems to be working ok here on mac mini. maybe we need more delay time between shut down and restart on faster systems?

I'm on M1 Max, maybe it makes the difference

update from dev

SirSevenG

Works for me

smk762 · 2022-12-06T08:16:43Z

on OSX app doesn't restart automatically for me after reset (didn't test on other OS yet)

coins list remain the same after restart, so this part works fine

relevant log:

[17:01:24] [info] [app.cpp:801] [2702049]: restarting the application
[17:01:24] [error] [app.cpp:815] [2702049]: Couldn't start a new process
[17:01:24] [debug] [app.cpp:651] [2702049]: will quit app, prevent all threading event
[17:01:24] [info] [mm2.service.cpp:295] [2702049]: destroying mm2 service...
[17:01:24] [info] [mm2.service.cpp:299] [2702049]: mm2 signals successfully disconnected
[17:01:24] [info] [mm2.service.cpp:307] [2702049]: processing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:303] [2702049]: preparing mm2 stop batch request
[17:01:24] [info] [mm2.service.cpp:310] [2702049]: mm2 stop batch answer received
[17:01:24] [info] [mm2.service.cpp:315] [2702049]: mm2 successfully stopped with rpc stop
[17:01:24] [info] [mm2.service.cpp:346] [2702049]: mm2 init thread destroyed
[17:01:24] [info] [mm2.service.cpp:348] [2702049]: mm2 service fully destroyed
[17:01:24] [info] [main.prerequisites.hpp:216] [2702049]: wally successfully cleaned
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [debug] [main.prerequisites.hpp:86] [2702049]: FatalErrorModal Destructed
[17:01:24] [info] [qt.orders.widget.cpp:35] [2702049]: qt_orders widget destroyed
[17:01:24] [info] [coingecko.wallet.charts.cpp:44] [2702049]: coingecko_wallet_charts_service destroyed

Can you please check if this still happens for you @tonymorony ?

SirSevenG

Rechecked on Win 11 and Mac, app restarts correctly, coins are up including zhtlc.

Canialon

Works good on Windows 10 and Mac
noticed that ARRR/ZOMBIE will start activation again if they were in activation process, nice:3

smk762 · 2022-12-10T16:01:02Z

^^

Can you please recheck this one @tonymorony ?

smk762 added 2 commits February 25, 2022 01:41

keep active coins when resetting config

03f1b74

remove logs

3ddfc0e

smk762 requested review from Milerius, a user and tonymorony February 24, 2022 18:06

Milerius suggested changes Feb 24, 2022

View reviewed changes

src/core/atomicdex/pages/qt.settings.page.cpp Outdated Show resolved Hide resolved

src/core/atomicdex/pages/qt.settings.page.cpp Outdated Show resolved Hide resolved

smk762 added 2 commits February 25, 2022 03:13

use unnordered set

7cd39db

smaller loop

3e2d944

smk762 requested a review from Milerius February 24, 2022 19:35

Milerius suggested changes Feb 24, 2022

View reviewed changes

src/core/atomicdex/pages/qt.settings.page.cpp Outdated Show resolved Hide resolved

rm useless if, rename set

fbe6347

smk762 requested a review from Milerius February 24, 2022 19:53

tonymorony added the 0.5.5 label Feb 25, 2022

ghost suggested changes Mar 1, 2022

View reviewed changes

src/core/atomicdex/pages/qt.settings.page.cpp Outdated Show resolved Hide resolved

src/core/atomicdex/pages/qt.settings.page.cpp Outdated Show resolved Hide resolved

fs -> file

6b3a384

smk762 requested a review from a user March 2, 2022 02:02

Merge pull request #1642 from KomodoPlatform/dev

97cc5af

merge from dev

ghost previously approved these changes Mar 2, 2022

View reviewed changes

tonymorony suggested changes Mar 2, 2022

View reviewed changes

tonymorony added 0.5.6 and removed 0.5.5 labels Mar 7, 2022

smk762 mentioned this pull request May 17, 2022

add coins #1740

Merged

code style

2414c92

smk762 dismissed ghost ’s stale review via 2414c92 May 17, 2022 12:00

Merge pull request #1771 from KomodoPlatform/dev

8d9dcd8

update from dev

smk762 mentioned this pull request May 17, 2022

[FEATURE REQUEST]: Hot reload coins file on launch #1773

Closed

smk762 added 2 commits September 13, 2022 19:57

rm log, fix file write

494befc

detect and repair invalid json

41cd270

smk762 mentioned this pull request Sep 13, 2022

restore default coins json if user json invalid #1967

Merged

2 tasks

SirSevenG previously approved these changes Sep 16, 2022

View reviewed changes

tonymorony marked this pull request as draft October 10, 2022 12:09

smk762 added 0.5.8 and removed next iteration to not forget to include it labels Nov 18, 2022

smk762 mentioned this pull request Nov 30, 2022

[FR]: Make solid auto-updater #2108

Closed

smk762 self-assigned this Dec 2, 2022

merge in dev

7c7ed9c

smk762 dismissed SirSevenG’s stale review via 7c7ed9c December 6, 2022 08:09

smk762 requested review from Milerius, SirSevenG and Canialon and removed request for Milerius December 6, 2022 08:16

smk762 marked this pull request as ready for review December 6, 2022 08:16

fix conflicts

20b879e

SirSevenG previously approved these changes Dec 9, 2022

View reviewed changes

merge dev and fix conflicts

61c9a91

smk762 dismissed SirSevenG’s stale review via 61c9a91 December 10, 2022 09:07

smk762 mentioned this pull request Dec 10, 2022

[BUG]: cfg.ini may not update correctly after app update #2133

Closed

cipig approved these changes Dec 10, 2022

View reviewed changes

Canialon approved these changes Dec 10, 2022

View reviewed changes

tonymorony approved these changes Dec 10, 2022

View reviewed changes

tonymorony merged commit 6e7b678 into dev Dec 10, 2022

smk762 mentioned this pull request Mar 6, 2023

0.5.7.1 RC #2159

Merged

smk762 deleted the keep_active_on_restart branch August 7, 2023 07:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keep active on restart #1632

Keep active on restart #1632

smk762 commented Feb 24, 2022 •

edited

Loading

tonymorony commented Mar 2, 2022

tonymorony left a comment

ghost commented Mar 2, 2022

smk762 commented Mar 2, 2022

tonymorony commented Mar 2, 2022

SirSevenG left a comment

smk762 commented Dec 6, 2022

SirSevenG left a comment

Canialon left a comment

smk762 commented Dec 10, 2022

Keep active on restart #1632

Keep active on restart #1632

Conversation

smk762 commented Feb 24, 2022 • edited Loading

tonymorony commented Mar 2, 2022

tonymorony left a comment

Choose a reason for hiding this comment

ghost commented Mar 2, 2022

smk762 commented Mar 2, 2022

tonymorony commented Mar 2, 2022

SirSevenG left a comment

Choose a reason for hiding this comment

smk762 commented Dec 6, 2022

SirSevenG left a comment

Choose a reason for hiding this comment

Canialon left a comment

Choose a reason for hiding this comment

smk762 commented Dec 10, 2022

smk762 commented Feb 24, 2022 •

edited

Loading