chore(toolchain): upgrade toolchain to nightly 1.86.0#2444
Merged
Conversation
Signed-off-by: Onur Özkan <work@onurozkan.dev>
… into toolchain-upgrade
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
|
It's ready now. cc @shamardy |
mariocynicys
reviewed
Jul 1, 2025
Collaborator
mariocynicys
left a comment
mariocynicys
left a comment
There was a problem hiding this comment.
midway through, i had to skim quickly over it as it was getting pretty lengthy.
seems benign though.
Collaborator
|
Getting these warnings warning: /atomicDEX-API/mm2src/mm2_bitcoin/chain/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024
warning: /atomicDEX-API/mm2src/mm2_bitcoin/primitives/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024
warning: /atomicDEX-API/mm2src/mm2_bitcoin/rpc/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024
warning: /atomicDEX-API/mm2src/mm2_bitcoin/script/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024
warning: /atomicDEX-API/mm2src/mm2_bitcoin/serialization_derive/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024
warning: /atomicDEX-API/Cargo.toml: unused manifest key: workspace.dependencies.tokio-tungstenite-wasm.defautl-features
warning: /atomicDEX-API/mm2src/mm2_bitcoin/keys/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024
warning: /atomicDEX-API/mm2src/mm2_bitcoin/crypto/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024
warning: /atomicDEX-API/mm2src/mm2_bitcoin/serialization/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2024Which I didn't get before the toolchain update, I think these should be fixed in this PR. |
shamardy
reviewed
Jul 2, 2025
Collaborator
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
First review iteration from my side!
… into toolchain-upgrade
This was referenced Jul 3, 2025
Signed-off-by: Onur Özkan <work@onurozkan.dev>
mariocynicys
reviewed
Jul 3, 2025
mariocynicys
approved these changes
Jul 3, 2025
Collaborator
mariocynicys
left a comment
mariocynicys
left a comment
There was a problem hiding this comment.
some stuff might have slipped but they wouldn't be that critical.
LGTM!
THANKS!
dimxy
pushed a commit
that referenced
this pull request
Jul 13, 2025
* dev: fix(eth): Correctly implement ETH max withdrawal logic (#2531) feat(use-clap-for-cli): use clap to parse CLI-Args #2215 (#2510) feat(orderbook): expirable maker orders (#2516) improvement(eth): drop parity support (#2527) chore(release): finalize changelog for v2.5.0-beta (#2524) chore(toolchain): upgrade toolchain to nightly 1.86.0 (#2444) feat(swap): rpc to find best swap with liquidity routing for ask (#2362) fix(kdf_walletconnect): apply explicit MmError mapping (#2514) fix(walletconnect): centralize connection and retry logic (#2508) fix(hw-wallet): avoid calling `get_enabled_address` in trezor-based coin init (#2504)
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Jul 16, 2025
* refactor-gas-fee-policy: (30 commits) revert change in test_enable_custom_erc20 fix(test) disable get_swap_gas_fee_policy for tests (no platform coin in tests) revert tokio test and use block_on for eth docker test Refactor gas fee code: get max_eth_tx_type from platform coin, add gas fee adjust coin params, rename "set_swap_transaction_fee_policy" rpc to "set_swap_gas_fee_policy", force set_swap_gas_fee_policy to store policy in the platform coin fix(eth): Propagate structured EIP-1559 fee errors (GLEECBTC#2532) fix(eth): Correctly implement ETH max withdrawal logic (GLEECBTC#2531) feat(use-clap-for-cli): use clap to parse CLI-Args GLEECBTC#2215 (GLEECBTC#2510) feat(orderbook): expirable maker orders (GLEECBTC#2516) improvement(eth): drop parity support (GLEECBTC#2527) chore(release): finalize changelog for v2.5.0-beta (GLEECBTC#2524) chore(toolchain): upgrade toolchain to nightly 1.86.0 (GLEECBTC#2444) feat(swap): rpc to find best swap with liquidity routing for ask (GLEECBTC#2362) fix(kdf_walletconnect): apply explicit MmError mapping (GLEECBTC#2514) fix(walletconnect): centralize connection and retry logic (GLEECBTC#2508) fix(hw-wallet): avoid calling `get_enabled_address` in trezor-based coin init (GLEECBTC#2504) chore(core): replace hash_raw_entry with stable entry() API (GLEECBTC#2473) chore(core): adapt `MmError` and usages for compatibility with new rustc versions (GLEECBTC#2443) feat(wallet): add `delete_wallet` RPC (GLEECBTC#2497) chore(release): add changelog entries for v2.5.0-beta (GLEECBTC#2494) chore(release): bump kdf version to 2.5.0-beta (GLEECBTC#2492) ... # Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/eth_swap_v2/eth_maker_swap_v2.rs # mm2src/coins/eth/eth_swap_v2/eth_taker_swap_v2.rs # mm2src/coins/eth/eth_utils.rs # mm2src/coins/eth/eth_withdraw.rs # mm2src/coins/eth/v2_activation.rs # mm2src/coins/lp_coins.rs # mm2src/coins/qrc20.rs # mm2src/coins/qrc20/swap.rs # mm2src/coins_activation/src/platform_coin_with_tokens.rs # mm2src/coins_activation/src/token.rs # mm2src/mm2_main/src/lp_swap/check_balance.rs # mm2src/mm2_main/src/lp_swap/maker_swap.rs # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs # mm2src/mm2_main/src/rpc/lp_commands/ext_api/ext_api_types.rs # mm2src/mm2_main/src/rpc/lp_commands/mod.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/errors.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/rpcs.rs # mm2src/mm2_main/src/rpc/lp_commands/tokens.rs # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs # mm2src/trading_api/src/one_inch_api/classic_swap_types.rs # mm2src/trading_api/src/one_inch_api/client.rs # mm2src/trading_api/src/one_inch_api/portfolio_types.rs
dimxy
pushed a commit
that referenced
this pull request
Aug 1, 2025
* dev: (21 commits) feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (#2454) ci(pull-requests): review notification bot (#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538) bless clippy (#2560) refactor(toolchain): use latest available stable compiler (#2557) feat(wallet): implement unified offline private key export API (#2542) improve note for docker test start failure (#2550) fix(DOCS): add note for macos to fix docker containers startup failure (#2544) refactor(toolchain): general stabilization for stable rust (#2528) fix(ci): adds nodejs 20 to ci-container (#2536) fix(WASM and Debian): fix build failures (#2534) improvement(event-streaming): impl DeriveStreamerId trait for all streamers (#2489) fix(eth): Propagate structured EIP-1559 fee errors (#2532) fix(eth): Correctly implement ETH max withdrawal logic (#2531) feat(use-clap-for-cli): use clap to parse CLI-Args #2215 (#2510) feat(orderbook): expirable maker orders (#2516) improvement(eth): drop parity support (#2527) chore(release): finalize changelog for v2.5.0-beta (#2524) chore(toolchain): upgrade toolchain to nightly 1.86.0 (#2444) ... # Conflicts: # mm2src/coins/lp_coins.rs # mm2src/coins/rpc_command/get_new_address.rs # mm2src/trezor/src/eth/eth_command.rs
dimxy
pushed a commit
that referenced
this pull request
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo...