fix(hw-wallet): avoid calling get_enabled_address in trezor-based coin init

[mariocynicys]

this makes it so we don't call get_enabled_address before initializing the coin, but rather after we made sure we initialized the account and address that the enabled address belongs to.
recently spent outputs is set at the beginning with a dummy output script and then changed to the correct one corresponding to the enabled address once we got it from the hardware wallet.

fixes #2502

[mariocynicys]

@takenagain could u please test if this works as expected?

also that the recently spent output script is set correctly (by adding a log line to mm2src/coins/utxo/utxo_common.rs - fn received_enabled_address_from_hw_wallet() that logs the address).

[shamardy]

@mariocynicys this PR should be based on the staging branch

[takenagain]

Activation is stuck in RequestingWalletBalance status for DOC.

{
  "mmrpc": "2.0",
  "result": {
    "status": "InProgress",
    "details": "RequestingWalletBalance"
  },
  "id": null
}

I added additional logging statements to mm2src/coins/coin_balance.rs -> fn enable_hd_wallet, and it appears to get stuck in get_enabled_address function. More specifically, it seems to be the get_account method in mm2src/coins/hd_wallet/mod.rs.

It has not reached received_enabled_address_from_hw_wallet in my testing so far.

See kdf.log with additional debug statements for DOC activation followed by MARTY activation attempt.

kdf.log without any local changes

RPC execution order

1. task::init_trezor::init
2. task::init_trezor::user_action
3. task::init_trezor::status
4. task::enable_utxo::init
5. task::enable_utxo::status

Run command:

MM_LOG=./kdf.log RUST_LOG=debug cargo run

DOC enable request

Limited to SSL & TCP electrums in testing.

{
  "userpass": "{{userpass}}",
  "mmrpc": "2.0",
  "method": "task::enable_utxo::init",
  "params": {
    "ticker": "DOC",
    "activation_params": {
      "mode": {
        "rpc": "Electrum",
        "rpc_data": {
          "servers": [
            {
              "url": "electrum1.cipig.net:10020",
              "contact": [
                {
                  "email": "cipi@komodoplatform.com"
                },
                {
                  "discord": "cipi#4502"
                }
              ],
              "protocol": "TCP"
            },
            {
              "url": "electrum1.cipig.net:20020",
              "protocol": "SSL",
              "contact": [
                {
                  "email": "cipi@komodoplatform.com"
                },
                {
                  "discord": "cipi#4502"
                }
              ]
            },
            {
              "url": "electrum2.cipig.net:10020",
              "contact": [
                {
                  "email": "cipi@komodoplatform.com"
                },
                {
                  "discord": "cipi#4502"
                }
              ],
              "protocol": "TCP"
            },
            {
              "url": "electrum2.cipig.net:20020",
              "protocol": "SSL",
              "contact": [
                {
                  "email": "cipi@komodoplatform.com"
                },
                {
                  "discord": "cipi#4502"
                }
              ]
            },
            {
              "url": "electrum3.cipig.net:10020",
              "contact": [
                {
                  "email": "cipi@komodoplatform.com"
                },
                {
                  "discord": "cipi#4502"
                }
              ],
              "protocol": "TCP"
            },
            {
              "url": "electrum3.cipig.net:20020",
              "protocol": "SSL",
              "contact": [
                {
                  "email": "cipi@komodoplatform.com"
                },
                {
                  "discord": "cipi#4502"
                }
              ]
            }
              ]
            }
          ]
        }
      },
      "tx_history": true,
      "priv_key_policy": "Trezor",
      "gap_limit": 20,
      "scan_policy": "scan_if_new_wallet",
      "min_addresses_number": 3
    }
  }
}

[mariocynicys]

@takenagain thanks for the investigation and logs, that came in handy :)

the issue seemed to be a deadlock due to issuing this get_enabled_address call while the accounts map was still locked after. now i let it drop early before this call. things should be fine now 🤞

[takenagain]

Thanks for the quick fix @mariocynicys!

Confirmed that it works as expected via Postman and the GUI with Trezor, HD, and non-HD (all expected addresses and balances discovered).

kdf.log - the log in received_enabled_address_from_hw_wallet is tagged with, "Enabled address for ".

[shamardy]

As this is a hotfix, all comments are for future reference.

[shamardy]

This code is repeated, you can refactor it in the other open PR as I am gonna merge this now

[shamardy]

I would prefer to have this in a separate trait in the future to start separating specific HW wallet code from the more general HD wallet code. This is not at all a priority at the current stage but we need it mentioned somewhere in our issues / checklists or at least a todo.