Skip to content

Update/fix type for (Immutable)MultiDict's *args#780

Closed
blueyed wants to merge 2 commits intoKludex:masterfrom
blueyed:typing-multidict-args-optional
Closed

Update/fix type for (Immutable)MultiDict's *args#780
blueyed wants to merge 2 commits intoKludex:masterfrom
blueyed:typing-multidict-args-optional

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 6, 2020

Tested/used in https://github.com/encode/starlette/blob/c80558e0/tests/test_datastructures.py#L325

Not included in #777 since this is not clear to me.

Fixes:

tests/test_datastructures.py:326: error: Argument 1 to "update" of "MultiDict" has incompatible type "None"; expected "Union[MultiDict, Mapping[Any, Any], List[Tuple[Any, Any]]]"

@blueyed blueyed mentioned this pull request Jan 6, 2020
@JayH5 JayH5 added the typing Type annotations or mypy issues label Sep 11, 2020
@Kludex
Copy link
Owner

Kludex commented Feb 1, 2022

This is being handled by #1449.

@Kludex Kludex closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typing Type annotations or mypy issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants