Closed
Conversation
blueyed
force-pushed
the
fix-typing
branch
2 times, most recently
from
24c5c61 to
6dfea84
Compare
blueyed
force-pushed
the
fix-typing
branch
2 times, most recently
from
9a4c14f to
8fd1663
Compare
Tests are using `int` and `float` there, and it should be `Any` in general.
| from starlette.types import Message, Receive, Scope, Send | ||
| from starlette.websockets import WebSocket | ||
|
|
||
| if False: # TYPE_CHECKING |
Contributor
There was a problem hiding this comment.
There's a built-in flag in typing for this :-)
Suggested change
| if False: # TYPE_CHECKING | |
| if typing.TYPE_CHECKING: |
Contributor
Author
There was a problem hiding this comment.
Yes, makes sense (given that this is py36+), thanks!
Not going to update it for now though, given its staleness already.
Contributor
|
What's the status of this PR? It contains the fix of one little typing annoyance I was going to suggest. |
and-semakin
reviewed
Oct 2, 2020
| return session | ||
|
|
||
| def __enter__(self) -> requests.Session: | ||
| def __enter__(self) -> "TestClient": |
Contributor
There was a problem hiding this comment.
Would be nice to have this fix merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypy starlette tests --ignore-missing-imports --check-untyped-defspassed (except for #780).