Add max_part_size parameter to MultiPartParser#2815
Merged
Kludex merged 11 commits intoKludex:masterfrom Dec 28, 2024
Merged
Conversation
Addresses issue reported in Kludex#2785
iudeen
commented
Dec 26, 2024
starlette/formparsers.py
Outdated
Comment on lines
132
to
133
| max_file_size: int = 1024 * 1024, # 1MB | ||
| max_part_size: int | float = 1024 * 1024, # 1MB |
Contributor
Author
There was a problem hiding this comment.
Should we remove defaults here and keep the default at top most function?
Kludex
reviewed
Dec 26, 2024
starlette/formparsers.py
Outdated
Comment on lines
132
to
133
| max_file_size: int = 1024 * 1024, # 1MB | ||
| max_part_size: int | float = 1024 * 1024, # 1MB |
Kludex
requested changes
Dec 26, 2024
iudeen
commented
Dec 26, 2024
Kludex
changed the title
max_part_size customizablemax_part_size parameter to MultiPartParser
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2785
Also addresses issue discussed in FastAPI Repo.