fix: make MultiPartParser read default max_part_size from the class attr#2915
Closed
reith wants to merge 2 commits intoKludex:masterfrom
Closed
fix: make MultiPartParser read default max_part_size from the class attr#2915reith wants to merge 2 commits intoKludex:masterfrom
reith wants to merge 2 commits intoKludex:masterfrom
Conversation
Owner
|
The class attributes should be removed, they are still there by mistake. FastAPI should be smart about this. |
Owner
|
That said... I understand it can be a bit annoying to have to wait for FastAPI... I think we need a constant |
Author
|
I ended up getting the raw request in my handler and using the Starlette's Request API there to change the part size limit. That’s better than changing the default since I perform authorization in a middleware, and it makes more sense not to raise the limit for unauthenticated requests. Thanks for being considerate, though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In FastAPI, the only way to change the maximum part size in a multipart request is to override
MultiPartParser.max_part_sizeglobally. That has stopped working since the changes introduced by this commit. I think the change in this PR is benign to keep. Even without considering compatibility with FastAPI, I think falling back to the class attribute to read the default value is a good idea but I don't mind if you think that problem should be addressed separately by FastAPI.Checklist