Fix port issue on host-based routing#1322
Conversation
|
If you accept this change, then we will need to update info in the documentation (I added a note in #1313). I can commit to this pull request, or create a new one. What should I do? |
|
Hey thanks for that. Surely a unit test can be added! |
Yes, I think we can update the doc in the same PR since they are related. |
|
I think that in general the pull request is ready. But I'm not sure about the quality of the wording in the note |
|
These errors are not caused by code, is it? |
Probably Github's issue:
|
|
It looks like is running now. I've relaunch the pipeline. |
aminalaee
left a comment
There was a problem hiding this comment.
LGTM. Thank you for this.
Host.host_regexis only used to check "Host" header: (routing.py:432)However, when generating
Host.host_regex, the port remained: (routing.py:149)I added one small fix. Now the port is also removed from
Host.host_regexUPD: Before this fix, the code from #1317 example returned
Not found, and afterHello World