Merged
Conversation
aminalaee
suggested changes
Oct 19, 2021
aminalaee
reviewed
Oct 23, 2021
Contributor
There was a problem hiding this comment.
...
routes = [
Host('api.example.org', api)
]
app = Starlette(routes=routes)
app.host('www.example.org', site)
news_host = Host('news.example.org', news)
app.router.routes.append(news_host)I think this is much better. Do you think we may need a little explanation here?
Contributor
Author
It'll do? I think that this does not make much sense, because the meaning from the upper sections is duplicated |
Contributor
|
That makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yesterday I wanted to use host-based routing, saw the necessary methods in the Starlette class, but did not find any info in docs. After searching, I found #363 and decided to add at least a minimal mention of host-based routing to the documentation.
#369 opened almost three years ago and is still open 🤡