feat: Add PSS signing and verifying #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones6
approved these changes
May 9, 2019
|
@billabt Would you be able to have a look at this and if you are happy squash merge and tag the change? |
|
We tested for Memory leaks and there aren't any in the new PSS paths. We did find one in make keys and have added a Deallocate to the |
|
@Andrew-Lees11 Had to change your available statements for using PSS. The correct iOS version is 11.0 not 10. It showed up here when I built the package for iOS something we don't do for CI. I fixed it after the merge. Just an FYI. |
|
@Andrew-Lees11 Had to make another change to the tests. They were generating warning on Swift 4.0.3. |
|
PSS is only supported from Swift 4.1 onwards which must be iOS 11. Thank you for spotting and fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds
usePSSflag to sign and verify. This allows you to use RSA-PSS for signing and verifying. If the flag is set to true the functions will useRSA_PKCS1_PSS_PADDING, a salt the length of the digest and MGF1 mask generation function to sign or verify.Motivation and Context
This change is required because "In general, RSA-PSS should be used as a replacement for RSA-PKCS#1 v1.5".
It also allows us to support PS256 and PS384 signing/verifying with JWTs as requested by SwiftJWT issue #55
How Has This Been Tested?
Tests have been added covering the new algorithms and the produced signatures have been tested against JWT.io both that one we create is valid and we can verify a valid one created by JWT.io.
Checklist: