Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PS256 #55

Closed
markm77 opened this issue May 5, 2019 · 6 comments
Closed

Support for PS256 #55

markm77 opened this issue May 5, 2019 · 6 comments
Assignees
Milestone

Comments

@markm77
Copy link

markm77 commented May 5, 2019

Hi there,

Any chance of support for PS256 on Linux? I am working with UK Open Banking which requires PS256 for message signing (*).

BR,
Mark

(*) https://openbanking.atlassian.net/wiki/spaces/DZ/pages/1077805207/Read+Write+Data+API+Specification+-+v3.1.2#Read/WriteDataAPISpecification-v3.1.2-ProcessforSigningaPayload

@Andrew-Lees11
Copy link
Contributor

Hello @markfinlabs
I have looked into implementing this and created a pull request against BlueRSA that adds RSA-PSS signing and verifying. Once this has been approved and merged it should be fairly simple to add PS256 and PS384 support to SwiftJWT.

@Andrew-Lees11 Andrew-Lees11 self-assigned this May 7, 2019
@Andrew-Lees11 Andrew-Lees11 added this to the 2019.10 milestone May 7, 2019
@markm77
Copy link
Author

markm77 commented May 7, 2019

Wow, that was super fast! Many thanks and much appreciated @Andrew-Lees11. I'm happy to test this on release and will report back here with my results.

BR,
Mark

@Andrew-Lees11
Copy link
Contributor

If you would like to test the PS256 support the ps256 branch has .ps256 and .ps384 algorithms available.

@markm77
Copy link
Author

markm77 commented May 13, 2019

Thanks @Andrew-Lees11, I should be able to test this later this week, feel free to move ahead without me if that's too slow for you. : ) Appreciate your efforts.

@Andrew-Lees11
Copy link
Contributor

Closing since this has now been merged and released in version 3.5.0.

@markm77
Copy link
Author

markm77 commented Aug 30, 2019

Just wanted to let you know I have been using this successfully - appreciate you adding this!

BR,
Mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants