Fix to account for cached body items when computing NodePath#7030
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
force-pushed
the
jtran/fix-artifact-graph-cache
branch
from
2236862 to
cddd9e4
Compare
jtran
force-pushed
the
jtran/fix-artifact-graph-cache
branch
from
cddd9e4 to
b907fc5
Compare
jessfraz
approved these changes
May 16, 2025
CodSpeed Instrumentation Performance ReportMerging #7030 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title says it all. We used to compute NodePath assuming we had the full AST, but we don't. We only have the part of the AST that is new, not cached.