Update getSketchExprsFromSelection to use codeRef.pathToNode#6737
Update getSketchExprsFromSelection to use codeRef.pathToNode#6737
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const sketchVariable = getNodeFromPath<VariableDeclarator>( | ||
| ast, | ||
| path, | ||
| s?.codeRef.pathToNode, |
There was a problem hiding this comment.
@Irev-Dev Mmmmh this change did break some of our sweep tests https://github.com/KittyCAD/modeling-app/actions/runs/14884043507/job/41798886884?pr=6737
There was a problem hiding this comment.
@jtran @Irev-Dev the tests that broke up there were in edit steps
Related https://github.com/KittyCAD/modeling-app/pull/6963/files#r2090752944
There was a problem hiding this comment.
Looks like we're back to green after 7030
|
Do you want to merge this so that we can start trying it in the main/nightly release? |
2 participants
Just a follow up from #6437
Part of #6650.