Skip to content

Remove last remnants of legacy positional call#6678

Merged
jtran merged 6 commits intomainfrom
jtran/rm-call-follow-up
May 3, 2025
Merged

Remove last remnants of legacy positional call#6678
jtran merged 6 commits intomainfrom
jtran/rm-call-follow-up

Conversation

@jtran
Copy link
Contributor

@jtran jtran commented May 2, 2025

Follow-up to #6639.

@qa-wolf
Copy link

qa-wolf bot commented May 2, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel
Copy link

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 10:22pm

@jtran jtran force-pushed the jtran/rm-call-follow-up branch from 26119f6 to 4510d3c Compare May 2, 2025 21:35
@jtran jtran marked this pull request as ready for review May 2, 2025 21:36
@jtran jtran requested a review from adamchalmers May 2, 2025 21:39
@jtran jtran enabled auto-merge (squash) May 2, 2025 21:39
@codspeed-hq
Copy link

codspeed-hq bot commented May 2, 2025

CodSpeed Instrumentation Performance Report

Merging #6678 will not alter performance

Comparing jtran/rm-call-follow-up (608dedd) with main (19f5031)

Summary

✅ 54 untouched benchmarks

@jtran jtran merged commit bc818f1 into main May 3, 2025
67 checks passed
@jtran jtran deleted the jtran/rm-call-follow-up branch May 3, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants