Merged
Conversation
In moreNodePathFromSourceRange, the `args` property may not be present if it's empty. So we should check args && before checking if args.length > 0.
It was looking for references to tags by finding kwarg labeled `tag=`. But that's used for DECLARING tags, not for REFERENCING them. Instead, it shouldn't really look at the kwarg labels at all. It should just find tag declarations and references by their type. This has a problem, in that if you assign a tag to an identifier, it won't find them. So... I guess... don't do that??? good enough for now.
It was identifying `x = b` (tag ref) as its target instead of `tag = $a` (tag decl)
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
To get started again run `nr test -- -t "testing source range to artifact startSketch on for a end cap that is also sketch on face on face" src/lib/selections.test.ts`
CodSpeed Instrumentation Performance ReportMerging #6639 will degrade performances by 40.02%Comparing Summary
Benchmarks breakdown
|
jtran
approved these changes
May 2, 2025
adamchalmers
force-pushed
the
achalmers/rm-callexpression
branch
from
ee59616 to
160a2d7
Compare
adamchalmers
added a commit
that referenced
this pull request
May 21, 2025
This has been enforced by the parser since #6639, so there's no need for `keywords = true` in every stdlib function anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users MUST use keyword call syntax now.
Closes #4600