Skip to content

Comments

only rust changes reset scene#6060

Merged
jessfraz merged 1 commit intomainfrom
only-rust-changes-reset-scene
Mar 29, 2025
Merged

only rust changes reset scene#6060
jessfraz merged 1 commit intomainfrom
only-rust-changes-reset-scene

Conversation

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Mar 29, 2025

this breaks #5975 into smaller chunks so as to get past playwirhgt failures from my huge change to planes

Signed-off-by: Jess Frazelle <github@jessfraz.com>
@qa-wolf
Copy link

qa-wolf bot commented Mar 29, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel
Copy link

vercel bot commented Mar 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Mar 29, 2025 5:41pm

@codecov
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.90%. Comparing base (6532b23) to head (fa374c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6060      +/-   ##
==========================================
- Coverage   85.91%   85.90%   -0.01%     
==========================================
  Files         113      113              
  Lines       44607    44684      +77     
==========================================
+ Hits        38322    38388      +66     
- Misses       6285     6296      +11     
Flag Coverage Δ
rust 85.90% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 29, 2025

CodSpeed Walltime Performance Report

Merging #6060 will degrade performances by 17.49%

Comparing only-rust-changes-reset-scene (fa374c0) with main (7ca3aff)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 13 improvements
❌ 43 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
execute_80-20-rail 4 s 3.4 s +16.84%
parse_80-20-rail 7.5 ms 8.8 ms -14.69%
parse_a-parametric-bearing-pillow-block 1.8 ms 2.1 ms -13.85%
parse_ball-bearing 3.2 ms 3.7 ms -15.28%
parse_bench 3 ms 3.6 ms -16.04%
parse_bracket 2.3 ms 2.7 ms -14.97%
parse_color-cube 2.3 ms 2.7 ms -16.13%
parse_cycloidal-gear 3.4 ms 4.1 ms -15.99%
execute_dodecahedron 1.8 s 1.6 s +13.62%
parse_dodecahedron 10.1 ms 12.1 ms -16.43%
parse_dual-basin-utility-sink 12.6 ms 15.1 ms -16.54%
execute_enclosure 3.3 s 2.9 s +14.31%
parse_enclosure 11 ms 12.9 ms -14.78%
execute_exhaust-manifold 2.1 s 1.9 s +11.08%
parse_exhaust-manifold 10.2 ms 12.1 ms -16.34%
parse_flange 1.1 ms 1.3 ms -13.76%
parse_focusrite-scarlett-mounting-bracket 8.3 ms 9.7 ms -13.87%
parse_food-service-spatula 11 ms 13 ms -15.96%
parse_french-press 10.4 ms 12.2 ms -14.59%
parse_gear-rack 2.1 ms 2.4 ms -14.41%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@jessfraz jessfraz merged commit 51c16d0 into main Mar 29, 2025
58 checks passed
@jessfraz jessfraz deleted the only-rust-changes-reset-scene branch March 29, 2025 18:43
modeling-app-github-app bot pushed a commit that referenced this pull request Mar 29, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Mar 29, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Mar 29, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
modeling-app-github-app bot pushed a commit that referenced this pull request Mar 29, 2025
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant