Skip to content

Comments

safe reset scene w cache#5975

Closed
jessfraz wants to merge 0 commit intomainfrom
safe-reset-scene
Closed

safe reset scene w cache#5975
jessfraz wants to merge 0 commit intomainfrom
safe-reset-scene

Conversation

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Mar 24, 2025

  • add rust test of empty ast, clear / bust, empty ast, then try to hide / show planes
  • this pr moves the artifact graph (small logic) that was left in engineConnection to kclManager. It also removes any and all defers around that code
  • it changes the show/hide plane logic based on the artifact graph to be linear

@qa-wolf
Copy link

qa-wolf bot commented Mar 24, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel
Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Mar 29, 2025 6:56pm

@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.90%. Comparing base (6532b23) to head (14f38b9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5975      +/-   ##
==========================================
- Coverage   85.91%   85.90%   -0.01%     
==========================================
  Files         113      113              
  Lines       44607    44684      +77     
==========================================
+ Hits        38322    38388      +66     
- Misses       6285     6296      +11     
Flag Coverage Δ
rust 85.90% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its concerning these changed #5799 when like we dont call this clear cache unless you cahnge files...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there must be a race i can't reproduce locally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and that function isn't firing, so gotta be a race

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 24, 2025

CodSpeed Walltime Performance Report

Merging #5975 will degrade performances by 17.7%

Comparing safe-reset-scene (14f38b9) with main (7ca3aff)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 10 improvements
❌ 43 regressions
✅ 39 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
parse_80-20-rail 7.5 ms 8.9 ms -16.1%
parse_a-parametric-bearing-pillow-block 1.8 ms 2.1 ms -15.17%
execute_ball-bearing 2 s 1.7 s +15.65%
parse_ball-bearing 3.2 ms 3.8 ms -15.59%
parse_bench 3 ms 3.7 ms -17.64%
parse_bracket 2.3 ms 2.8 ms -16.93%
parse_color-cube 2.3 ms 2.7 ms -16.64%
execute_cycloidal-gear 1.3 s 1.2 s +11.15%
parse_cycloidal-gear 3.4 ms 4.1 ms -16.57%
execute_dodecahedron 1.8 s 1.6 s +17.43%
parse_dodecahedron 10.1 ms 12.1 ms -16.65%
parse_dual-basin-utility-sink 12.6 ms 15.3 ms -17.61%
execute_enclosure 3.3 s 3 s +10.85%
parse_enclosure 11 ms 13 ms -15.77%
parse_exhaust-manifold 10.2 ms 12.2 ms -16.58%
parse_flange 1.1 ms 1.3 ms -14.97%
parse_focusrite-scarlett-mounting-bracket 8.3 ms 9.7 ms -14.24%
parse_food-service-spatula 11 ms 12.9 ms -15.39%
parse_french-press 10.4 ms 12.3 ms -15.73%
parse_gear-rack 2.1 ms 2.5 ms -16.04%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants