Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Change to a Rails 4 ActiveModel validator. #11

Closed
wants to merge 1 commit into from
Closed

feature: Change to a Rails 4 ActiveModel validator. #11

wants to merge 1 commit into from

Commits on Feb 17, 2020

  1. feature: Change to a Rails 4 ActiveModel validator. 

    Rails 4 introduced ActiveModel, ActiveModel::Validations and
ActiveModel::EachValidator.

Instead of injecting ourselves into ActiveRecord::Base, we will be
automatically picked up. This fixes KimNorgaard#1.

We can now also be used on ActiveModel as well as ActiveRecord. This
simplifies testing.

Also
* rspec-rails was dropped becasue it seems to want all of Rails loaded.
  We only needed one convenience method, errors_on. It has been copied into our test model.
* Bumped our runtime dependency to activemodel >= 4.0. Dropped the others.
* Dropped the development dependency on all of Rails. We only need ActiveModel.
    @schwern
    schwern committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    b197c81 View commit details
    Browse the repository at this point in the history