gem? #1
Comments
|
thx! |
|
Saw you are making changes to the gemspec. You should not make this dependent on v3 of Rails. |
|
Care to elaborate on your view? I havn't tested it with rails-versions below 3, but if you can confirm that it works with other versions, then I won't mind removing the dependency. |
|
I have been using it with Rails 3 and Rails 4 just fine. The way you have the gemfile configured now, it will only work with Rails 3.0.x, meaning it won't even run with Rails 3.2. I would just drop the version requirement on Rails entirely as it seems to work fine. You can check some other validation gems for comparison. |
|
Right, I removed the dependencies on specific versions and pushed 1.0.4.Thanks for the input. |
schwern
added a commit
to evalEmpire/validates_hostname
that referenced
this issue
Feb 17, 2020
Rails 4 introduced ActiveModel, ActiveModel::Validations and ActiveModel::EachValidator. Instead of injecting ourselves into ActiveRecord::Base, we will be automatically picked up. This fixes KimNorgaard#1. We can now also be used on ActiveModel as well as ActiveRecord. This simplifies testing. Also * rspec-rails was dropped becasue it seems to want all of Rails loaded. We only needed one convenience method, errors_on. It has been copied into our test model. * Bumped our runtime dependency to activemodel >= 4.0. Dropped the others. * Dropped the development dependency on all of Rails. We only need ActiveModel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Would you consider pushing a gem to rubygems?
The text was updated successfully, but these errors were encountered: