fix(vscode): fix hanging sessions for permissions bug - #9450
Merged
Conversation
…pprovals stuck This prevents dead permission buttons and failed settings saves when the same permission was already answered from another panel or worktree.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (14 files)
Reviewed by gpt-5.5-2026-04-23 · 4,642,416 tokens |
# Conflicts: # .kilo/package-lock.json # .kilocode/package-lock.json # packages/kilo-vscode/webview-ui/src/types/messages.ts # packages/opencode/src/server/routes/instance/permission.ts
Add kilocode_change markers to shared opencode files and provide missing PermissionContext methods in permission-recovery test.
…/kilocode into fix/hanging-sessions-v2
Contributor
Author
|
Additional manual test passed with Tested:
Verified:
|
Contributor
Author
|
Manual test passed. Tested:
Verified:
|
imanolmzd-svg
suggested changes
Apr 28, 2026
imanolmzd-svg
approved these changes
Apr 28, 2026
jliounis
pushed a commit
to jliounis/kilocode
that referenced
this pull request
May 18, 2026
fix(vscode): fix hanging sessions for permissions bug
This was referenced Jun 11, 2026
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
fix(vscode): fix hanging sessions for permissions bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #9283
Sometimes a permission pop-up stayed on screen after it was already answered somewhere else. That left broken buttons behind and could also make settings save fail for no good reason.
What changed
Permission replies now go back to the workspace that asked for them, even if the session came from another panel or worktree. If the app learns that a prompt was already handled, it clears the old prompt instead of leaving a dead button on screen. The server now says when a permission is gone, and the client uses that to refresh cleanly. This also keeps the same stale case from breaking settings saves and makes the behavior match in both permission paths.
How to test