fix(vscode): dismiss stale permission responses - #11118
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The implementation is correct. Files Reviewed (3 files)
Fix these issues in Kilo Cloud Reviewed by claude-4.6-sonnet-20260217 · 243,021 tokens Review guidance: REVIEW.md from base branch |
imanolmzd-svg
approved these changes
Jun 11, 2026
marius-kilocode
enabled auto-merge
June 11, 2026 12:59
NJ-2020
pushed a commit
to NJ-2020/kilocode
that referenced
this pull request
Jul 4, 2026
…lo-Org#11118) Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
…lo-Org#11118) Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
t7tran
pushed a commit
to t7tran/kilocode
that referenced
this pull request
Aug 14, 2026
fix(vscode): dismiss stale permission responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #10822 changed SDK failures produced with
throwOnErrorfrom structured top-level objects into realErrorinstances whose HTTP status and response body live undercause. The VS Code permission handler still inspected only top-level fields, so it stopped recognizing the 404 returned when another panel, auto-approve flow, or covered permission rule had already resolved the same request.That race is expected because multiple mounted views can observe a permission before the backend resolution event reaches all of them. Since the stale detector missed the wrapped shape, selecting persistent permission rules could log
Failed to save always-rules, show an error toast, and leave an obsolete prompt visible. This regressed the stale-prompt recovery introduced in #9450.This change recognizes both the existing direct error shapes and the SDK-wrapped
cause.status/cause.bodyshape. A stale save or reply now clears the request and refreshes pending permissions, while non-404 failures continue through the normal error path. Regression coverage exercises wrapped 404s in both persistence and reply paths and verifies that wrapped server errors are not misclassified.