fix(vscode): stop code action providers from interfering with quick fixes - #9330
Closed
markijbema wants to merge 4 commits into
Closed
fix(vscode): stop code action providers from interfering with quick fixes#9330markijbema wants to merge 4 commits into
markijbema wants to merge 4 commits into
Conversation
…ixes AutocompleteCodeActionProvider unconditionally injected a QuickFix into every Ctrl+. menu regardless of whether autocomplete was enabled, adding noise to the quick fix list. Gate it behind the enableSmartInlineTaskKeybinding setting so it only appears when autocomplete shortcuts are active. KiloCodeActionProvider marked "Fix with Kilo Code" as isPreferred, which caused it to hijack VS Code's auto-fix behavior over language server fixes that provide actual code edits. Remove the preferred flag so language server fixes take priority. Closes #8522
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 changed file, 7 total carried forward)
Fix these issues in Kilo Cloud Reviewed by gpt-5.5-20260423 · 707,896 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutocompleteCodeActionProviderbehind theenableSmartInlineTaskKeybindingsetting so it stops injecting a "Suggested Edits" QuickFix into everyCtrl+./Cmd+.menu when autocomplete is disabledisPreferredfrom "Fix with Kilo Code" code action so it doesn't hijack VS Code's auto-fix over language server fixes that provide actual code editsContext
This is a follow-up to #8508 which fixed the keybinding conflict (the
cycleAgentModecommand was globally bound toCtrl+./Cmd+.without awhenclause). That fix addressed the primary breakage, but two code action provider issues remained:AutocompleteCodeActionProviderwas registered with"*"document selector and unconditionally returned a QuickFix action on everyprovideCodeActionscall — regardless of whether autocomplete was enabled, adding noise to every quick fix menuKiloCodeActionProvidermarked "Fix with Kilo Code" asisPreferred: true, which caused it to be selected byeditor.action.autoFixover language server fixes that provide actual inline code edits (Kilo's action opens a chat, not a direct fix)Closes #8522
Test plan
bun test tests/unit/code-action-provider.test.ts— 13 pass)Ctrl+.menu no longer shows "Kilo Code: Suggested Edits"editor.action.autoFixno longer selects "Fix with Kilo Code" over actual language server fixes