Skip to content

fix(vscode): stop code action providers from interfering with quick fixes - #8523

Closed
kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
fix/quickfix-code-action-interference
Closed

fix(vscode): stop code action providers from interfering with quick fixes#8523
kilo-code-bot[bot] wants to merge 1 commit into
mainfrom
fix/quickfix-code-action-interference

Conversation

@kilo-code-bot

@kilo-code-bot kilo-code-bot Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Gate AutocompleteCodeActionProvider behind the enableSmartInlineTaskKeybinding setting so it stops injecting a "Suggested Edits" QuickFix into every Ctrl+. / Cmd+. menu when autocomplete is disabled
  • Remove isPreferred from "Fix with Kilo Code" code action so it doesn't hijack VS Code's auto-fix over language server fixes that provide actual code edits

Context

This is a follow-up to #8508 which fixed the keybinding conflict (the cycleAgentMode command was globally bound to Ctrl+./Cmd+. without a when clause). That fix addressed the primary breakage, but two code action provider issues remained:

  1. AutocompleteCodeActionProvider was registered with "*" document selector and unconditionally returned a QuickFix action on every provideCodeActions call — regardless of whether autocomplete was enabled, adding noise to every quick fix menu
  2. KiloCodeActionProvider marked "Fix with Kilo Code" as isPreferred: true, which caused it to be selected by editor.action.autoFix over language server fixes that provide actual inline code edits (Kilo's action opens a chat, not a direct fix)

Closes #8522

Test plan

  • Existing unit tests updated and passing (bun test tests/unit/code-action-provider.test.ts — 13 pass)
  • With autocomplete disabled: Ctrl+. menu no longer shows "Kilo Code: Suggested Edits"
  • With autocomplete enabled: "Kilo Code: Suggested Edits" still appears as before
  • editor.action.autoFix no longer selects "Fix with Kilo Code" over actual language server fixes

…ixes

AutocompleteCodeActionProvider unconditionally injected a QuickFix into
every Ctrl+. menu regardless of whether autocomplete was enabled, adding
noise to the quick fix list. Gate it behind the enableSmartInlineTaskKeybinding
setting so it only appears when autocomplete shortcuts are active.

KiloCodeActionProvider marked "Fix with Kilo Code" as isPreferred, which
caused it to hijack VS Code's auto-fix behavior over language server fixes
that provide actual code edits. Remove the preferred flag so language
server fixes take priority.

Closes #8522
@kilo-code-bot

kilo-code-bot Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • packages/kilo-vscode/src/services/autocomplete/AutocompleteCodeActionProvider.ts
  • packages/kilo-vscode/src/services/autocomplete/AutocompleteServiceManager.ts
  • packages/kilo-vscode/src/services/code-actions/code-action-provider.ts
  • packages/kilo-vscode/tests/unit/code-action-provider.test.ts

Reviewed by gpt-5.4-20260305 · 168,208 tokens

@markijbema

Copy link
Copy Markdown
Contributor

Closing to recreate this PR with the correct author. Replacement PR link will be added shortly.

@markijbema markijbema closed this Apr 21, 2026
@markijbema

Copy link
Copy Markdown
Contributor

Recreated as #9330 to fix the PR author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick fixes (Ctrl+. / Cmd+.) broken by code action provider interference

1 participant