Fix/minimax-tool-call-id-string: Coerce all tool call IDs to strings regardless of the model/provider#5816
Merged
kevinvandijk merged 5 commits intoKilo-Org:mainfrom Feb 13, 2026
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🦋 Changeset detectedLatest commit: 0fc6ecc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Feb 13, 2026
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I discovered this error when asking Kilo CLI to summarize a different PR's changes (screenshot attached). Interestingly, when I asked it to retry, the issue did not occur again.
Some providers (e.g. MiniMax via Kilo's OpenRouter provider) return tool call
idas a number instead of a string, violating the OpenAI-compatible spec. This causes downstream failures when the ID is expected to be a string.Implementation
Rather than patching individual provider handlers (whack-a-mole), the fix coerces
idto a string inNativeToolCallParser.processRawChunk()-- the shared entry point that all providers flow through. This ensures any provider returning a non-string ID is normalized before the value propagates further.idasrawIdand applyString()coercion when non-nullScreenshots
How to Test
Expected id to be a stringerrorOr run the unit tests:
Get in Touch
@ evan.discorb