Honor explicit 'disable' for reasoning effort#5739
Merged
kevinvandijk merged 4 commits intoKilo-Org:mainfrom Feb 15, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: fc02342 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
jeremylongshore
added a commit
to jeremylongshore/kilocode
that referenced
this pull request
Feb 14, 2026
jeremylongshore
added a commit
to jeremylongshore/kilocode
that referenced
this pull request
Feb 14, 2026
- Add .reviews/README.md: case study framing for AI-assisted PR review - Add 6 test evidence logs (combined batches + mega-combined) - Copy evidence logs to 13 individual PR directories - Update 13 status.json files with test_results + evidence_log refs - Total: ~38,000 lines of raw terminal output as proof of work Test runs (all fresh, turbo cache cleared): Batch 1: PRs Kilo-Org#5370+5660+5704 — 7,859 passed Individual: PR Kilo-Org#5562 — 7,803 passed Batch 2: PRs Kilo-Org#5739+5817 — 7,938 passed Batch 3: PRs Kilo-Org#5331+5568 — 7,935 passed Batch 4: PRs Kilo-Org#5667+5728+5807+5865+5869 — 7,935 passed Mega-combined: 11 PRs merged — 7,938 passed Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jeremylongshore
added a commit
to jeremylongshore/kilocode
that referenced
this pull request
Feb 15, 2026
Mirror: Honor explicit 'disable' for reasoning effort (Kilo-Org#5739)
This was referenced Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses critical issues with the
reasoning_effortimplementation for the OpenAI Compatible provider. Previously, selecting the "disable" option in the UI did not actually prevent the provider from sending reasoning parameters (specifically binarythinking) to the API. Additionally, the UI state was prone to desynchronization because the settings wrapper was dropping non-reasoning fields.Implementation
BaseOpenAiCompatibleProviderto implement anisExplicitlyDisabledcheck. This check ensures that if the user selects "disable", boththinking: { type: "enabled" }andreasoning_effortparameters are omitted from the final API request.ThinkingBudgetcomponent wrapper inOpenAICompatible.tsxto forward all configuration fields to the parent state handler. This prevents settings likethinkingBudgetfrom being lost and ensures the UI correctly reflects the "disabled" state when selected.Screenshots
How to Test
thinkingnorreasoning_effortis sent in the request body.apiConfigurationwithout losing other related fields likethinkingBudget.Get in Touch
If you have any questions about these changes, feel free to reach out!