Conversation
🦋 Changeset detectedLatest commit: 3634b4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (4 files) |
…locode into christiaan/suggestions
| // Must be called before early return to satisfy React hooks rules | ||
| const shuffledIdeas = useMemo( | ||
| () => | ||
| [...Object.values(t("ideaSuggestionsBox.ideas", { returnObjects: true }) as Record<string, string>)] |
There was a problem hiding this comment.
WARNING: Potential runtime/UX issue if i18n data is missing or misconfigured
react-i18next can return a fallback string for missing keys; with returnObjects: true that can still end up being a string at runtime. In that case Object.values(...) will produce an array of characters (or throw if the value is null/undefined), leading to odd suggestion content or a crash. Consider validating the t(...) result is an object before calling Object.values, and falling back to an empty list (or a known default set).
Uh oh!
There was an error while loading. Please reload this page.