Merged
Conversation
…n (#10736) Co-authored-by: Roo Code <roomote@roocode.com>
🦋 Changeset detectedLatest commit: da9d5e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fd16b51 to
ce427c1
Compare
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)The PR adds several duplicate type definitions that already exist in the file:
These appear to be from an upstream merge and may be intentional, but should be reviewed for cleanup. Files Reviewed (24 files)
|
markijbema
reviewed
Jan 21, 2026
|
|
||
| Add support for OpenAI Codex subscriptions (thanks Roo) | ||
|
|
||
| - Fix: Reset invalid model selection when using OpenAI Codex provider (PR #10777 by @hannesrudolph) |
Contributor
There was a problem hiding this comment.
these PR numbers dont make a lot of sense in our repo, should these be urls?
markijbema
reviewed
Jan 21, 2026
markijbema
reviewed
Jan 21, 2026
markijbema
approved these changes
Jan 21, 2026
Merged
PeterDaveHello
added a commit
to PeterDaveHelloKitchen/kilocode
that referenced
this pull request
Jan 22, 2026
## Problem PR Kilo-Org#5270 (merged 2026-01-21) added openai-codex provider support but did not include the TypeScript type definition in @kilocode/core-schemas. This causes compilation errors when code attempts to handle openai-codex in switch statements: error TS2678: Type '"openai-codex"' is not comparable to type ... The provider was added to: - cli/src/constants/providers/validation.ts (runtime validation) - cli/src/constants/providers/labels.ts (UI labels) - cli/src/constants/providers/settings.ts (default settings) But missing from: - packages/core-schemas/src/config/provider.ts (TypeScript types) ## Impact Any code using switch/case on provider.provider that includes openai-codex will fail TypeScript compilation. This blocks: - CLI providers API command (needs to map openai-codex model field) - Any future switch-based provider handling logic ## Solution This adds the missing type definition: - Created openAICodexProviderSchema with apiModelId field - Added to providerConfigSchema discriminated union (line 396) - Exported OpenAICodexProviderConfig type (line 442) openai-codex now matches the pattern of openai-native (both use apiModelId). ## Verification Type checking now passes: pnpm check-types # No errors in @kilocode/core-schemas or @kilocode/cli Related: Kilo-Org#5270
PeterDaveHello
added a commit
to PeterDaveHelloKitchen/kilocode
that referenced
this pull request
Jan 23, 2026
## Problem PR Kilo-Org#5270 (merged 2026-01-21) added openai-codex provider support but did not include the TypeScript type definition in @kilocode/core-schemas. This causes compilation errors when code attempts to handle openai-codex in switch statements: error TS2678: Type '"openai-codex"' is not comparable to type ... The provider was added to: - cli/src/constants/providers/validation.ts (runtime validation) - cli/src/constants/providers/labels.ts (UI labels) - cli/src/constants/providers/settings.ts (default settings) But missing from: - packages/core-schemas/src/config/provider.ts (TypeScript types) - cli/src/config/mapper.ts (model field mapping) ## Impact Any code using switch/case on provider.provider that includes openai-codex will fail TypeScript compilation. This blocks: - CLI providers API command (needs to map openai-codex model field) - Any future switch-based provider handling logic ## Solution This adds the missing type definition: - Created openAICodexProviderSchema with apiModelId field - Added to providerConfigSchema discriminated union (line 396) - Exported OpenAICodexProviderConfig type (line 442) - Added openai-codex mapping in CLI provider model handling (apiModelId) openai-codex now matches the pattern of openai-native (both use apiModelId). ## Verification Type checking: pnpm check-types CLI tests: cd cli && pnpm test Related: Kilo-Org#5270
PeterDaveHello
added a commit
to PeterDaveHelloKitchen/kilocode
that referenced
this pull request
Jan 23, 2026
## Problem PR Kilo-Org#5270 (merged 2026-01-21) added openai-codex provider support but did not include the TypeScript type definition in @kilocode/core-schemas. This causes compilation errors when code attempts to handle openai-codex in switch statements: error TS2678: Type '"openai-codex"' is not comparable to type ... The provider was added to: - cli/src/constants/providers/validation.ts (runtime validation) - cli/src/constants/providers/labels.ts (UI labels) - cli/src/constants/providers/settings.ts (default settings) But missing from: - packages/core-schemas/src/config/provider.ts (TypeScript types) - cli/src/config/mapper.ts (model field mapping) ## Impact Any code using switch/case on provider.provider that includes openai-codex will fail TypeScript compilation. This blocks: - CLI providers API command (needs to map openai-codex model field) - Any future switch-based provider handling logic ## Solution This adds the missing type definition: - Created openAICodexProviderSchema with apiModelId field - Added to providerConfigSchema discriminated union (line 396) - Exported OpenAICodexProviderConfig type (line 442) - Added openai-codex mapping in CLI provider model handling (apiModelId) openai-codex now matches the pattern of openai-native (both use apiModelId). ## Verification Type checking: pnpm check-types CLI tests: cd cli && pnpm test Related: Kilo-Org#5270
maywzh
pushed a commit
to maywzh/kilocode
that referenced
this pull request
Jan 25, 2026
Add OpenAI codex provider
maywzh
pushed a commit
to maywzh/kilocode
that referenced
this pull request
Jan 25, 2026
Add OpenAI codex provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for OpenAI Codex subscriptions, cherry-picked from Roo