fix: remove double scrollbar in model dropdown and make search sticky#5235
Closed
nevermind-bro wants to merge 3 commits intoKilo-Org:mainfrom
Closed
fix: remove double scrollbar in model dropdown and make search sticky#5235nevermind-bro wants to merge 3 commits intoKilo-Org:mainfrom
nevermind-bro wants to merge 3 commits intoKilo-Org:mainfrom
Conversation
- Remove overflow-y-auto from ModelSelector contentClassName to prevent double scrollbar - Restructure SelectDropdown to use flex layout with sticky search box - Make search input stay fixed at top while scrolling through models - Keep single scrollbar on items container only Fixes issue where model dropdown showed two scrollbars and search box would scroll out of view when browsing through model list.
🦋 Changeset detectedLatest commit: 95bd5ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
Hi @kevinvandijk , can you please review this PR. |
Collaborator
|
Thank you for this! We eventually went with #5583 because of the smaller diff but appreciated regardless! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the double scrollbar issue in the model selection dropdown and makes the search box sticky.
Problem
Solution
overflow-y-autofrom outer containerTesting
Screenshots
Before
After
Screen.Recording.2026-01-20.at.5.04.28.PM.mov
Test Cases
Fixes #5033