fix(cli): improve --continue flag reliability with Promise-based response handling#5141
Merged
marius-kilocode merged 2 commits intoKilo-Org:mainfrom Jan 17, 2026
Conversation
…onse handling Replace fixed 2-second setTimeout with proper Promise-based request/response pattern for task history requests. This ensures the CLI waits for an actual response rather than hoping the arbitrary delay is enough. Changes: - Use addPendingRequestAtom/removePendingRequestAtom for request tracking - Add 5-second timeout with clear error message - Improve error handling to distinguish timeout from other errors - Add comprehensive tests for task history pending request atoms
🦋 Changeset detectedLatest commit: e32611c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
marius-kilocode
approved these changes
Jan 17, 2026
Collaborator
|
@PeterDaveHello thanks! |
Merged
This was referenced Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
addPendingRequestAtom/removePendingRequestAtomfor request trackingTest plan
pnpm test src/state/atoms/__tests__/taskHistory.test.ts)