Fix number key hotkeys (1, 2, 3) not working in command approval menu#4978
Merged
marius-kilocode merged 2 commits intomainfrom Jan 13, 2026
Merged
Fix number key hotkeys (1, 2, 3) not working in command approval menu#4978marius-kilocode merged 2 commits intomainfrom
marius-kilocode merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 4082a13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR adds support for number key hotkeys (1, 2, 3) in the CLI command approval menu. The implementation is clean and well-tested. Key Changes:
Code Quality:
Files Reviewed (3 files)
|
RSO
approved these changes
Jan 13, 2026
This was referenced Jan 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where pressing number keys (1, 2, 3) to select "Always Run" options in the CLI command approval menu didn't work.
Problem
When the approval menu displayed options like:
Pressing 'y' and 'n' worked correctly, but pressing '1', '2', or '3' did nothing.
Root Cause
The
handleApprovalKeysfunction incli/src/state/atoms/keyboard.tsonly handleddown,up,y,n,return, andescapekeys. Number keys were never checked against the approval options' hotkeys.Solution
Added hotkey matching logic at the beginning of
handleApprovalKeysto find options by their hotkey and execute them when a matching number key is pressed.