Skip to content

Conversation

@markijbema
Copy link
Contributor

@markijbema markijbema commented Jan 7, 2026

Summary

Removes the unused ContinueCompletionProvider class and all code exclusively used by it, which is not needed by our active GhostInlineCompletionProvider.

If we want to use some of this code later we can always copy paste it, but from our previous work we've concluded that cherry-picking part by part is easier than wholesale integration

Context for doing that now is that I want to start integrating the continue code into our own code more

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026

⚠️ No Changeset found

Latest commit: dc6d476

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markijbema markijbema force-pushed the mark/remove-continue-completion-provider branch from 59b539c to dc6d476 Compare January 14, 2026 08:38
@markijbema markijbema marked this pull request as ready for review January 14, 2026 08:41
@kiloconnect
Copy link
Contributor

kiloconnect bot commented Jan 14, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

This PR removes unused ContinueCompletionProvider and all NextEdit-related code that is not needed by the active GhostInlineCompletionProvider. The changes are straightforward deletions of unused code.

Key Changes:

  • Removed IAutocompleteNextEditLLM interface from index.d.ts
  • Removed nextEdit capability from ModelCapability interface
  • Removed RangeInFileWithNextEditInfo interface
  • Updated MinimalConfig.ts comments to reflect removal of NextEdit references
  • Deleted entire nextEdit/ directory with all providers, templating, and context code
  • Deleted vscode-test-harness/ files related to completion provider, window manager, and selection change handling
  • Deleted autodetect.ts and its tests for NextEdit model detection

The deletions are clean and the remaining code in MinimalConfig.ts and index.d.ts is consistent with the removal of NextEdit functionality.

Files Reviewed (57 files)
  • src/services/continuedev/core/autocomplete/MinimalConfig.ts - Comment updates only
  • src/services/continuedev/core/index.d.ts - Interface removals
  • src/services/continuedev/core/llm/autodetect.test.ts - Deleted
  • src/services/continuedev/core/llm/autodetect.ts - Deleted
  • src/services/continuedev/core/nextEdit/ - Entire directory deleted (40+ files)
  • src/services/continuedev/core/vscode-test-harness/ - Multiple files deleted

Copy link
Contributor

@EamonNerbonne EamonNerbonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

Woot!

@markijbema markijbema merged commit a522dc6 into main Jan 14, 2026
22 checks passed
@markijbema markijbema deleted the mark/remove-continue-completion-provider branch January 14, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants