Skip to content

Allow null for tool arguments - #4815

Merged
chrarnoldus merged 4 commits into
mainfrom
christiaan/null
Jan 6, 2026
Merged

Allow null for tool arguments#4815
chrarnoldus merged 4 commits into
mainfrom
christiaan/null

Conversation

@chrarnoldus

Copy link
Copy Markdown
Collaborator

No description provided.

@changeset-bot

changeset-bot Bot commented Jan 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1530050

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
kilo-code Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kilo-code-bot

kilo-code-bot Bot commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

This PR correctly allows null values in tool argument types for OpenAI strict mode. The change comments out code that was incorrectly stripping null from nullable types (e.g., ["string", "null"]"string"). According to the OpenAI documentation, nullable types are supported in strict mode.

The change is properly marked with kilocode_change markers as required by the project guidelines.

Files Reviewed (2 files)
  • .changeset/stupid-mayflies-pay.md - Changeset for the patch
  • src/api/providers/base-provider.ts - Comments out null-stripping logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants