refactor: simplify GhostProviderTester to use shared utility functions #4207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
- Use extractPrefixSuffix() and contextToAutocompleteInput() from types module - Remove manual AutocompleteInput construction - Improve mock context provider typing with GhostContextProvider interface - Remove unused imports (vscode, crypto, AutocompleteInput)
markijbema
force-pushed
the
mark/refactor-ghost-provider-tester-more-productioncode
branch
from
93b461a to
e3ee5c2
Compare
chrarnoldus
approved these changes
Dec 5, 2025
markijbema
deleted the
mark/refactor-ghost-provider-tester-more-productioncode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goal: less difference with the actual production code, less code in the eval-framework. We do need the big mock, as that will become the input object emulating the vscode state