-
Notifications
You must be signed in to change notification settings - Fork 1.5k
track sessions from the extension #4066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7fbea75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
otherwise tests can't resolve imports
chrarnoldus
approved these changes
Dec 1, 2025
This was referenced Dec 1, 2025
Merged
This was referenced Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In #3868, I implemented session tracking support in the CLI. This PR is the beginning of a series of PRs porting that functionality over to the extension.
In this initial PR, the extension tracks sessions for every conversation.
Implementation
In order to avoid copying code between the CLI and the extension, the
ServiceManagerclass was extracted and all its platform-specific dependencies were extracted and turned into interfaces, allowing specific platforms (cli and the extension) to pass their own implementations in.Screenshots
N/A
How to Test
Start a new conversation in the extension, and afterwards do
/session listin the cli - you should be able to see your convo from the extension.