-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CLI - Fix welcome msg #3497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI - Fix welcome msg #3497
Conversation
🦋 Changeset detectedLatest commit: bb917a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors message generation logic by extracting duplicated timestamp and ID generation code into a centralized generateMessage() utility function. Additionally, it fixes a typo in the changeset documentation.
- Extracts common message ID and timestamp generation logic into a reusable utility function
- Replaces inline ID/timestamp generation across three files with the new utility
- Updates welcome message timestamp from 0 to 1
- Corrects spelling error in changeset
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| cli/src/ui/utils/messages.ts | New utility file containing the generateMessage() function for consistent message ID and timestamp generation |
| cli/src/utils/notifications.ts | Refactored to use generateMessage() instead of inline timestamp/ID generation |
| cli/src/utils/auto-update.ts | Refactored to use generateMessage() instead of inline timestamp/ID generation |
| cli/src/ui/utils/welcomeMessage.ts | Refactored to use generateMessage() and changed welcome message timestamp from 0 to 1 |
| .changeset/thirty-kings-tickle.md | Fixed typo "Wellcome" to "Welcome" |
Context
Implementation
Screenshots