autocomplete code improvements #3396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a cached suggestion was available, getFromLLM() would return an empty GhostSuggestionsState, causing the cached suggestion to never be used. This resulted in unnecessary LLM calls and poor performance. Now properly constructs and returns a GhostSuggestionsState containing the cached suggestion, allowing the cache to work as intended.
Previously, the cancellation token parameter was ignored (prefixed with _), meaning VSCode's cancellation requests would not stop ongoing LLM requests. This could lead to wasted API calls and resources. Now listens to token.onCancellationRequested and calls cancelRequest() to properly handle cancellation. Includes guard for test compatibility where the mock token may not have this method.
The cache check in getFromLLM() was redundant because provideInlineCompletionItems() already checks the cache before calling getFromLLM(). This duplication added unnecessary complexity and made the code flow harder to understand. Removed the cache check from getFromLLM() to simplify the code and establish a clear separation of concerns: provideInlineCompletionItems() handles caching, getFromLLM() handles LLM requests.
The local variable 'context' was shadowing the function parameter 'context' (vscode.InlineCompletionContext), making the code harder to read and potentially confusing for maintainers. Renamed the local variable to 'suggestionContext' to clearly distinguish it from the parameter and improve code clarity.
Removed console.log statement that was left in production code for debugging purposes. This reduces console noise and follows best practices for production code.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llm generated, needs selfrreview