Skip to content

fix(vscode): align answered question font with tool output - #13667

Merged
marius-kilocode merged 3 commits into
mainfrom
indecisive-pilot
Sep 1, 2026
Merged

fix(vscode): align answered question font with tool output#13667
marius-kilocode merged 3 commits into
mainfrom
indecisive-pilot

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Answered question text was larger than nearby tool text and retained a fixed 13px size when the Kilo font size changed.

Why This Change Was Made

Use the same scalable 12px token as tool output and explicitly inherit it on question items. This overrides the fixed upstream item style without changing upstream files or the interactive question dock.

User Impact

Completed question and answer text fits the session typography and scales with the Kilo font size setting. Colors, wrapping, and collapse controls stay unchanged.

Evidence

  • Extension compile (including lint and host/webview typechecks), explicit typecheck, formatting, marker guard, and all 4 font architecture tests pass.
  • Isolated VS Code self-test used deterministic transcript data, with no model calls. Verified long-question wrapping and collapse/expand. Both question and answer compute to 12px at the default setting and 14.7692px with font size 16, with no horizontal overflow.
  • Screenshots show the same fixture and sidebar width before and after rebuilding and restarting the extension. Images were reviewed for privacy and are hosted outside this repository.

Before

Before: answered question text is larger than the adjacent tool labels

After

After: answered question text matches tool typography

Manual Test

Open an answered question, collapse and expand it, then change the Kilo font size. Confirm that question and answer text scale together and long text wraps without clipping.

CI test repair

The JetBrains worktree test fixture passed its shared coroutine scope to each session UI. Disposing the shown session cancelled that scope and raced the delete job. The fixture now uses production-style child scopes, and the deletion test gates the request to verify disposal does not cancel it. Production JetBrains code is unchanged. All 32 targeted tests and JetBrains typecheck pass locally; the full VS Code unit suite passes (4,584 passed, 1 skipped), as does Knip. JetBrains Detekt reports 1,902 existing issues.

@kilo-code-bot

kilo-code-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (5 files)
  • .changeset/question-output-font.md
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/labs-tool-call-lab/search-previews-chromium-linux.png
  • packages/kilo-jetbrains/frontend/src/test/kotlin/ai/kilocode/client/agentManager/worktree/WorktreeSessionEditorManagerTest.kt
  • packages/kilo-ui/src/components/message-part.css
  • packages/kilo-vscode/tests/unit/font-size-arch.test.ts
Previous Review Summary (commit fe799ba)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit fe799ba)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • .changeset/question-output-font.md
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/labs-tool-call-lab/search-previews-chromium-linux.png
  • packages/kilo-ui/src/components/message-part.css
  • packages/kilo-vscode/tests/unit/font-size-arch.test.ts

Reviewed by grok-4.6 · Input: 284.5K · Output: 6.4K · Cached: 46.3K

Review guidance: REVIEW.md from base branch main

@WebReflection WebReflection left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: .kt !

@marius-kilocode
marius-kilocode merged commit 3dff75d into main Sep 1, 2026
36 checks passed
@marius-kilocode
marius-kilocode deleted the indecisive-pilot branch September 1, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants