Skip to content

refactor(kilo-console): share available provider selection - #13664

Merged
marius-kilocode merged 1 commit into
mainfrom
dedupe-c-connected-providers
Sep 1, 2026
Merged

refactor(kilo-console): share available provider selection#13664
marius-kilocode merged 1 commit into
mainfrom
dedupe-c-connected-providers

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Agents and Models repeat the same provider filtering and Kilo-first ordering.

Why This Change Was Made

Move that pure selection into available in the existing models state module. Both caller-owned memos remain. Keep flattening, favorite matching, picker choices, and selection/save behavior unchanged. Reuse the identical comparator already in models instead of keeping a second copy.

User Impact

No intended behavior change. The list still includes configured or connected providers, excludes providers with no models, puts Kilo first, and sorts the rest by provider name. Missing snapshot data still produces an empty list.

Evidence

  • Three files: 13 additions and 38 deletions, net 25 fewer lines (13 production and 12 allowlist). No new files, dependencies, or tests.
  • Existing console suite: 33 pass. Typecheck and production build pass. Focused lint has zero errors and two existing warnings; build retains its existing large-chunk warning. git diff check passes.
  • Direct smoke checks of the actual helper pass for missing data, configured/connected union, empty-model exclusion, Kilo-first/name ordering, and unchanged input. The in-memory fixture used an isolated HOME/XDG profile and blocked network access; the profile was removed. No live model or UI requests.
  • Fresh report: 22 to 21 duplicate pairs, 426 to 404 duplicated lines, 2922 to 2758 duplicated tokens. Only fingerprint 1da5f78ab9ff1975 removed; duplication ratchet passes.

@kilo-code-bot

kilo-code-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • packages/kilo-console/src/routes/config/state/agents.ts
  • packages/kilo-console/src/routes/config/state/models.ts
  • script/kilocode-duplication-allowlist.json

Reviewed by grok-4.6 · Input: 124.6K · Output: 4.6K · Cached: 117.5K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit c09f89d into main Sep 1, 2026
31 checks passed
@marius-kilocode
marius-kilocode deleted the dedupe-c-connected-providers branch September 1, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants