Skip to content

refactor(vscode): reuse metadata leaf validators - #13660

Merged
marius-kilocode merged 1 commit into
mainfrom
dedupe-a-sixth-host-group
Sep 1, 2026
Merged

refactor(vscode): reuse metadata leaf validators#13660
marius-kilocode merged 1 commit into
mainfrom
dedupe-a-sixth-host-group

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Browser feedback and review-comment metadata repeat the same object, bounded-string, and optional-positive-integer validators.

Why This Change Was Made

Export the existing review-comment validators and reuse them through browser feedback’s existing import. Keep local aliases and all callers unchanged. The validator bodies are identical; field limits, URL handling, path checks, and higher-level parsing stay separate.

User Impact

No behavior change is intended. The PR removes 9 net production lines across two files. No new files, test code, dependencies, or generic validation framework are added.

Evidence

  • 82 existing browser-feedback, review-comment, and PR-comment tests passed, including metadata round trips and malformed/oversized fields.
  • Host/webview typecheck, lint, knip, build:check, formatting, duplication guard, and diff checks passed.
  • Duplication report unchanged: 25 pairs, 490 lines, 3391 tokens. These leaf duplicates are below the scanner threshold; the allowlist is untouched.
  • The pending inline-review PR was inspected: it does not change these validator bodies.
  • Pure validation reuse was checked through existing tests. No UI session or model requests were needed.

No changeset is needed for this internal behavior-preserving refactor.

@kilo-code-bot

kilo-code-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • packages/kilo-vscode/src/shared/browser-feedback.ts
  • packages/kilo-vscode/src/shared/review-comments.ts

Reviewed by grok-4.6 · Input: 64.9K · Output: 5.2K · Cached: 189.4K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 521feb8 into main Sep 1, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the dedupe-a-sixth-host-group branch September 1, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants