refactor(vscode): reuse metadata leaf validators - #13660
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 64.9K · Output: 5.2K · Cached: 189.4K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 1, 2026 11:35
iscekic
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Browser feedback and review-comment metadata repeat the same object, bounded-string, and optional-positive-integer validators.
Why This Change Was Made
Export the existing review-comment validators and reuse them through browser feedback’s existing import. Keep local aliases and all callers unchanged. The validator bodies are identical; field limits, URL handling, path checks, and higher-level parsing stay separate.
User Impact
No behavior change is intended. The PR removes 9 net production lines across two files. No new files, test code, dependencies, or generic validation framework are added.
Evidence
No changeset is needed for this internal behavior-preserving refactor.