Skip to content

refactor(kilo-console): share CLI settings toggle - #13658

Merged
marius-kilocode merged 1 commit into
mainfrom
dedupe-c-config-toggle
Sep 1, 2026
Merged

refactor(kilo-console): share CLI settings toggle#13658
marius-kilocode merged 1 commit into
mainfrom
dedupe-c-config-toggle

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

CLI UI and CLI Notifications each define the same stateless toggle button.

Why This Change Was Made

Move the identical JSX into ConfigToggle in the existing ConfigPage module. Both routes import it under their existing Toggle name, so all five call sites, props, reactive reads, state, and save logic remain unchanged. Keep the different Indexing toggle out of scope.

User Impact

No intended visual or behavior change. Button type, disabled state, aria-pressed, selected class, click handling, label, description, and On/Off badge are preserved.

Evidence

  • Three production files plus one allowlist entry: 27 additions and 64 deletions, net 37 fewer lines (25 production and 12 allowlist).
  • No new files, dependencies, or tests. Console suite: 33 tests pass; typecheck and production build pass. Lint has zero warnings/errors; formatting and diff checks pass. Build retains its existing large-chunk warning.
  • Fresh duplication report: 25 to 24 pairs, 490 to 465 duplicated lines, 3391 to 3248 duplicated tokens. Only fingerprint 3d8c2a788d682c4e removed; ratchet passes.
  • JSX and call-site comparison verifies a mechanical move. No interactive UI smoke was run. Manual check: toggle settings on both pages with mouse and keyboard; turning attention alerts off must disable desktop notifications and sound.

@kilo-code-bot

kilo-code-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • packages/kilo-console/src/routes/config/CliNotificationsRoute.tsx
  • packages/kilo-console/src/routes/config/CliUiRoute.tsx
  • packages/kilo-console/src/routes/config/ConfigPage.tsx
  • script/kilocode-duplication-allowlist.json

Reviewed by grok-4.6 · Input: 59.2K · Output: 3.3K · Cached: 129.2K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 2eaff40 into main Sep 1, 2026
31 checks passed
@marius-kilocode
marius-kilocode deleted the dedupe-c-config-toggle branch September 1, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants