refactor(kilo-console): share CLI settings toggle - #13658
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by grok-4.6 · Input: 59.2K · Output: 3.3K · Cached: 129.2K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 1, 2026 11:25
WebReflection
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
CLI UI and CLI Notifications each define the same stateless toggle button.
Why This Change Was Made
Move the identical JSX into ConfigToggle in the existing ConfigPage module. Both routes import it under their existing Toggle name, so all five call sites, props, reactive reads, state, and save logic remain unchanged. Keep the different Indexing toggle out of scope.
User Impact
No intended visual or behavior change. Button type, disabled state, aria-pressed, selected class, click handling, label, description, and On/Off badge are preserved.
Evidence