Skip to content

refactor(vscode): reuse Markdown fence formatting - #13657

Merged
marius-kilocode merged 1 commit into
mainfrom
dedupe-a-fifth-host-group
Sep 1, 2026
Merged

refactor(vscode): reuse Markdown fence formatting#13657
marius-kilocode merged 1 commit into
mainfrom
dedupe-a-fifth-host-group

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Browser feedback and review comments duplicate the same Markdown fence construction.

Why This Change Was Made

Export the existing review-comment helper and reuse it through browser feedback’s existing import. The six-line helper body is identical in both modules and remains unchanged, including backtick-run handling. Nearby escaping and validation logic stays separate.

User Impact

No behavior change is intended. The PR removes 7 net production lines across two files, with no new files, dependencies, or test code.

Evidence

  • 82 existing review-comment, PR-comment, and browser-feedback tests passed.
  • Host/webview typecheck, lint, knip, build:check, formatting, duplication guard, and diff checks passed.
  • Duplication report unchanged at 27 pairs, 521 lines, 3646 tokens. This smaller clone is below the scanner threshold; the allowlist is untouched.
  • Exact overlap was inspected: the pending inline-review PR changes other sections of review-comments.ts, not this fence helper.
  • Pure formatter reuse is covered through existing tests; no UI session or model requests were needed.

No changeset is needed for this internal behavior-preserving refactor.

@kilo-code-bot

kilo-code-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • packages/kilo-vscode/src/shared/browser-feedback.ts
  • packages/kilo-vscode/src/shared/review-comments.ts

Reviewed by grok-4.6 · Input: 40.8K · Output: 3.4K · Cached: 205.7K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 1ab7e3a into main Sep 1, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the dedupe-a-fifth-host-group branch September 1, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants