Skip to content

refactor(vscode): share autocomplete FIM model selection - #13655

Merged
marius-kilocode merged 1 commit into
mainfrom
dedupe-a-fourth-host-group
Sep 1, 2026
Merged

refactor(vscode): share autocomplete FIM model selection#13655
marius-kilocode merged 1 commit into
mainfrom
dedupe-a-fourth-host-group

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Notebook and chat autocomplete duplicate the same model fallback selection for Next Edit models.

Why This Change Was Made

Move the identical selector into the existing FIM module that both callers already import. Preserve the notebookModel and getChatAutocompleteModel exports through aliases. Model catalogs, settings, credentials, request routing, and streaming are unchanged.

User Impact

No behavior change is intended. Next Edit models still use their configured FIM fallback; FIM selections still return the same model object. The PR removes 7 net production lines across three files, with no new files or test changes.

Evidence

  • 21 existing selector and chat autocomplete tests pass, including gateway/direct-provider Next Edit fallback and FIM passthrough.
  • Host/webview typecheck, lint, knip, build:check, formatting, duplication guard, and diff checks pass.
  • Duplication report unchanged at 27 pairs, 521 lines, 3646 tokens. This five-line duplicate is below the scanner threshold; no allowlist changes were made.
  • The pure selector is covered by existing tests. No model requests or manual UI session were needed.

No changeset is needed for this internal behavior-preserving refactor.

@kilo-code-bot

kilo-code-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • packages/kilo-vscode/src/services/autocomplete/AutocompleteServiceManager.ts
  • packages/kilo-vscode/src/services/autocomplete/chat-autocomplete/ChatTextAreaAutocomplete.ts
  • packages/kilo-vscode/src/services/autocomplete/fim.ts

Reviewed by grok-4.6 · Input: 77.4K · Output: 5K · Cached: 205.8K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit ddf42be into main Sep 1, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the dedupe-a-fourth-host-group branch September 1, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants