refactor(cli): reuse config overlay reader after updates - #13654
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 132.8K · Output: 6K · Cached: 172.7K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 1, 2026 10:55
iscekic
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Config overlay updates repeat the same auth, account, config, and source reads used by the existing overlay reader.
Why This Change Was Made
Call the existing overlay Effect after a successful update instead of maintaining a second resolution block. Keep write locking, conflicts, invalidation, events, and disposal ordering unchanged. The request InstanceRef remains the same; project disposal is registered for pre-response and global disposal still follows resolution.
User Impact
No intended HTTP or config behavior change. Scope, fallback behavior, read concurrency, and response construction stay the same. Diagnostic tracing gains a nested ConfigConsoleHttpApi.overlay span under overlayUpdate.
Evidence