Skip to content

refactor(cli): reuse config overlay reader after updates - #13654

Merged
marius-kilocode merged 1 commit into
mainfrom
dedupe-c-config-overlay
Sep 1, 2026
Merged

refactor(cli): reuse config overlay reader after updates#13654
marius-kilocode merged 1 commit into
mainfrom
dedupe-c-config-overlay

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Config overlay updates repeat the same auth, account, config, and source reads used by the existing overlay reader.

Why This Change Was Made

Call the existing overlay Effect after a successful update instead of maintaining a second resolution block. Keep write locking, conflicts, invalidation, events, and disposal ordering unchanged. The request InstanceRef remains the same; project disposal is registered for pre-response and global disposal still follows resolution.

User Impact

No intended HTTP or config behavior change. Scope, fallback behavior, read concurrency, and response construction stay the same. Diagnostic tracing gains a nested ConfigConsoleHttpApi.overlay span under overlayUpdate.

Evidence

  • Two files: 1 added line, 42 removed, net 41 fewer lines (29 production plus 12 allowlist). No new helpers, public exports, dependencies, or tests.
  • All 47 existing config-overlay, httpapi-instance-context, and httpapi-error-middleware tests pass. These exercise real HTTP reads and writes, response freshness, conflicts, and disposal behavior with temporary fixtures.
  • CLI typecheck, focused lint (zero warnings/errors), annotations, and git diff check pass.
  • Fresh report: 27 to 26 duplicate pairs, 521 to 502 duplicated lines, 3646 to 3513 duplicated tokens. Only fingerprint ec31254ab83e4a2a removed; duplication ratchet passes.
  • No manual UI launch was needed for this internal reuse; the existing HTTP regression tests cover the affected paths.

@kilo-code-bot

kilo-code-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • packages/opencode/src/kilocode/server/httpapi/handlers/config-console.ts
  • script/kilocode-duplication-allowlist.json

Reviewed by grok-4.6 · Input: 132.8K · Output: 6K · Cached: 172.7K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 9d1c0d1 into main Sep 1, 2026
45 of 48 checks passed
@marius-kilocode
marius-kilocode deleted the dedupe-c-config-overlay branch September 1, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants