Skip to content

refactor(kilo-console): remove duplicate remote MCP normalization - #13653

Merged
marius-kilocode merged 1 commit into
mainfrom
dedupe-c-mcp-normalization
Sep 1, 2026
Merged

refactor(kilo-console): remove duplicate remote MCP normalization#13653
marius-kilocode merged 1 commit into
mainfrom
dedupe-c-mcp-normalization

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

MCP marketplace normalization has two adjacent branches with identical remote-config handling. The first checks type=remote plus a string URL; the second accepts any string URL.

Why This Change Was Made

Delete the narrower duplicate branch. Its inputs now reach the identical broader branch. Local command-array handling remains first, so its precedence is unchanged. Headers, OAuth, enabled state, timeout, and fallback behavior remain unchanged.

User Impact

No intended behavior change. Explicit remote and URL-only marketplace entries use the same existing normalization path.

Evidence

  • Two files, 22 lines removed and zero added: 10 production lines plus the 12-line verified allowlist entry. No new helpers, exports, dependencies, or tests.
  • Fresh duplication report: 30 to 29 pairs, 575 to 565 duplicated lines, 4043 to 3914 duplicated tokens. Only fingerprint 64494aa992cccc8d removed; ratchet passes.
  • Console suite: 33 tests pass. Console typecheck and production build pass. Focused lint has zero errors and 13 existing warnings; build retains the existing large-chunk warning. git diff check passes.
  • The removed body is identical to its immediate successor, whose predicate includes every removed case. No live MCP server or manual UI flow was needed for this internal branch deletion.

@kilo-code-bot

kilo-code-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • packages/kilo-console/src/routes/config/state/mcp.ts
  • script/kilocode-duplication-allowlist.json

Reviewed by grok-4.6 · Input: 68.5K · Output: 3.5K · Cached: 126.3K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit b7d1527 into main Sep 1, 2026
31 checks passed
@marius-kilocode
marius-kilocode deleted the dedupe-c-mcp-normalization branch September 1, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants