refactor(gateway): share device authorization HTTP requests - #13642
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Previous Review Summary (commit 149eeca)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 149eeca)Status: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by grok-4.6 · Input: 111.1K · Output: 6.4K · Cached: 128.3K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 1, 2026 09:00
marius-kilocode
disabled auto-merge
September 1, 2026 09:00
marius-kilocode
enabled auto-merge
September 1, 2026 09:16
WebReflection
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The legacy and TUI device-auth flows duplicate the same initiation POST and polling GET logic.
Why This Change Was Made
Move only the identical HTTP functions into an internal auth helper. Keep both public entrypoints and their browser, progress, callback, credential, and organization-selection behavior unchanged. No new public exports, dependencies, retries, or validation.
User Impact
No intended behavior change. Request shapes, initiation 429 text, polling 202/403/410 mappings, generic errors, JSON passthrough, and network/JSON failures are preserved.
Evidence