refactor(cli): remove built-in WarpGrep - #13084
Conversation
49ddb39 to
43df520
Compare
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Incremental review of Fix these issues in Kilo Cloud Issue Details (click to expand)SUGGESTION
Files Reviewed (54 files)
Previous Review Summary (commit 43df520)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 43df520)Status: 2 Issues Found | Recommendation: Address before merge Overview
The removal is thorough and internally consistent: tool, registry, agent permissions, sandbox classification, config schema, settings UI, i18n, docs, SDK/OpenAPI, and tests are all updated, and a grep of the PR head shows no stale Fix these issues in Kilo Cloud Issue Details (click to expand)SUGGESTION
Files Reviewed (54 files)
Reviewed by kimi-k3 · Input: 81.4K · Output: 3.3K · Cached: 161.3K Review guidance: REVIEW.md from base branch |
43df520 to
fe453de
Compare
Issue
Fixes #12787
Context
Kilo currently bundles the experimental Morph WarpGrep implementation and
@morphllm/morphsdkfor every CLI and extension build, even whenexperimental.codebase_searchis disabled. The SDK transitively pulls platform-specific ripgrep packages into the distribution and caused the missing-package warning reported in #12787 during ordinary extension use.This dependency chain has caused several recent packaging and runtime issues. For example, #13065 attempted to work around WarpGrep’s platform-specific @vscode/ripgrep resolution failure in packaged builds.
Remove the built-in experiment and its unconditional packaging burden. Kilo's normal grep/file search and semantic search remain available.
Existing configurations that contain
experimental.codebase_searchcontinue to load: Kilo warns that the setting is retired, ignores it before strict parsing, and preserves unrelated configuration values.Implementation
semantic_searchtool.The official Morph OpenCode plugin may be an opt-in migration path, but it is not treated as drop-in compatible here and this PR does not add a network-dependent integration.
Screenshots / Video
N/A — this removes an experimental settings toggle; there is no replacement visual flow.
How to Test
Manual/local verification
experimental.codebase_search: true:bun run dev debug config --pure --print-logs --log-level INFOignored retired experimental.codebase_search config, preserved unrelatedusernameandbatch_toolvalues, and excludedcodebase_searchfrom resolved config.Reviewer test steps
experimental.codebase_search: truealongside another experimental setting such asbatch_tool: truein a disposable Kilo config.bun run dev debug config --pure --print-logs --log-level INFO.batch_toolremains enabled, andcodebase_searchis absent from resolved config.packages/opencode, runbun test ./test/kilocode/config/config.test.tsand the focused tool-registry/sandbox tests touched by this change.Agent-executed verification:
build:check,knip, and marker guard passed.git diff --checkguards passed.safe to mergewith no runtime defects.Checklist