fix(cli): use system ripgrep in packaged builds - #12789
Conversation
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (3 files in incremental diff)
Both previous findings on Fix these issues in Kilo Cloud Previous Review Summaries (2 snapshots, latest commit e86d98b)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit e86d98b)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (1 file in incremental diff)
The previous review's finding about the bare Fix these issues in Kilo Cloud Previous review (commit 2077f02)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (3 files)
The build-plugin approach itself looks well scoped for fork hygiene: the shared-file change is a single plugin registration in Reviewed by claude-opus-5 · Input: 44 · Output: 12.1K · Cached: 1.2M Review guidance: REVIEW.md from base branch |
|
@Hardik180704 please stop the automation on our issues. We need high quality contributions where implementation and functionality was verified by a human. Thanks. |
|
Understood, and I apologize. I’ll stop the automated issue-claiming and PR activity on the repository. I appreciate the feedback, and I’ll ensure that any future contribution is personally reviewed and functionally verified by me before I post or open anything. Thank you for clarifying your expectations. |
|
@marius-kilocode, if you have the time, could you please take one final look at my currently open PRs? Please feel free to close any that do not meet the project’s quality standards. I completely understand and will respect your judgment. There is no obligation to review them immediately, and I will not submit further automated contributions. Thank you. |
|
@Hardik180704 please manually test all of your PR's and post proof. I won't review a PR that hasn't been tested/reviewed by the contributor. |
|
@marius-kilocode |
|
Thanks for the contribution! Closing this PR as it was superseded by #13084. |
Summary
@vscode/ripgrepimport to its existing PATH-based fallback in compiled CLI buildsWhy
The VS Code extension bundles a compiled CLI without a
node_modulestree. Morph's local code-search provider attempted to resolve a platform-specific optional package before its system-ripgrep fallback could run, producing a runtime error on macOS ARM64.Validation
Fixes #12787